-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix try wrapping expression in variant
suggestion with struct field shorthand
#92808
Fix try wrapping expression in variant
suggestion with struct field shorthand
#92808
Conversation
469ed0b
to
5dfaf5f
Compare
r? @camelid I fixed those places you asked for, and did some drive-by fixes as well. |
The error output looks really nice, but unfortunately I don't think I have time to review the rest of this PR :) r? @davidtwco |
This comment has been minimized.
This comment has been minimized.
5dfaf5f
to
272fb23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing, this looks great.
@bors r+ rollup |
📌 Commit 272fb23 has been approved by |
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#92795 (Link sidebar "location" heading to top of page) - rust-lang#92799 (Remove some unnecessary uses of `FieldDef::ident`) - rust-lang#92808 (Fix `try wrapping expression in variant` suggestion with struct field shorthand) - rust-lang#92819 (rustdoc: remove hand-rolled isatty) - rust-lang#92876 (Fix suggesting turbofish with lifetime arguments) - rust-lang#92921 (Rename Printer constructor from mk_printer() to Printer::new()) - rust-lang#92937 (rustdoc: Add missing dot separator) - rust-lang#92953 (Copy an example to PartialOrd as well) - rust-lang#92977 (Docs: recommend VecDeque instead of Vec::remove(0)) - rust-lang#92981 (fix const_ptr_offset_from tracking issue) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes a broken suggestion: playground
before:
after:
r? @m-ou-se
since you touched the code last in #91080