Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intra-doc: Make Receiver::into_iter into a clickable link #92525

Merged
merged 1 commit into from
Jan 4, 2022
Merged

intra-doc: Make Receiver::into_iter into a clickable link #92525

merged 1 commit into from
Jan 4, 2022

Conversation

zohnannor
Copy link
Contributor

The documentation on std::sync::mpsc::Iter and std::sync::mpsc::TryIter provides links to the corresponding Receiver methods, unlike std::sync::mpsc::IntoIter does.

This was left out in c59b188
Related to #29377

The documentation on `std::sync::mpsc::Iter` and `std::sync::mpsc::TryIter` provides links to the corresponding `Receiver` methods, unlike `std::sync::mpsc::IntoIter` does.

This was left out in c59b188
Related to #29377
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2022
@zohnannor
Copy link
Contributor Author

@rustbot label +A-intra-doc-links

@rustbot rustbot added the A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name label Jan 3, 2022
@zohnannor zohnannor changed the title Make Receiver::into_iter into a clickable link intra-doc: Make Receiver::into_iter into a clickable link Jan 3, 2022
@camelid camelid added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jan 4, 2022
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was even pointed out in the PR that added it, but it seems it was never fixed.

@camelid
Copy link
Member

camelid commented Jan 4, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 4, 2022

📌 Commit ca3f904 has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2022
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91754 (Modifications to `std::io::Stdin` on Windows so that there is no longer a 4-byte buffer minimum in read().)
 - rust-lang#91884 (Constify `Box<T, A>` methods)
 - rust-lang#92107 (Actually set IMAGE_SCN_LNK_REMOVE for .rmeta)
 - rust-lang#92456 (Make the documentation of builtin macro attributes accessible)
 - rust-lang#92507 (Suggest single quotes when char expected, str provided)
 - rust-lang#92525 (intra-doc: Make `Receiver::into_iter` into a clickable link)
 - rust-lang#92532 (revert rust-lang#92254 "Bump gsgdt to 0.1.3")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b2d6ff4 into rust-lang:master Jan 4, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 4, 2022
@zohnannor zohnannor deleted the patch-1 branch January 4, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants