-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate Result's and Option's methods into fewer impl blocks #92444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
added
the
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Dec 30, 2021
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 30, 2021
rustbot
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Dec 30, 2021
dtolnay
removed
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Dec 30, 2021
Looking at the UI test updates, I like the net effect of this on the error messages. @bors r+ |
📌 Commit 5960f7a has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 1, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#90102 (Remove `NullOp::Box`) - rust-lang#92011 (Use field span in `rustc_macros` when emitting decode call) - rust-lang#92402 (Suggest while let x = y when encountering while x = y) - rust-lang#92409 (Couple of libtest cleanups) - rust-lang#92418 (Fix spacing in pretty printed PatKind::Struct with no fields) - rust-lang#92444 (Consolidate Result's and Option's methods into fewer impl blocks) Failed merges: - rust-lang#92483 (Stabilize `result_cloned` and `result_copied`) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 4, 2022
Move `contains` method of Option and Result lower in docs Follow-up to rust-lang#92444 trying to get the `Option` and `Result` rustdocs in better shape. This addresses the request in rust-lang#62358 (comment). The `contains` methods are previously too high up in the docs on both `Option` and `Result` — stuff like `ok` and `map` and `and_then` should all be featured higher than `contains`. All of those are more ubiquitously useful than `contains`.
dtolnay
added
A-docs
Area: Documentation for any part of the project, including the compiler, standard library, and tools
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result
's andOption
's methods have historically been separated up intoimpl
blocks based on their trait bounds, with the bounds specified on type parameters of the impl block. I find this unhelpful because closely related methods, likeunwrap_or
andunwrap_or_default
, end up disproportionately far apart in source code and rustdocs:I'd prefer for method to be in as few impl blocks as possible, with the most logical grouping within each impl block. Any bounds needed can be written as
where
clauses on the method instead:Warning: the end-to-end diff of this PR is computed confusingly by git / rendered confusingly by GitHub; it's practically impossible to review that way. I've broken the PR into commits that move small groups of methods for which git behaves better — these each should be easily individually reviewable.