Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libssh2-sys #92374

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Update libssh2-sys #92374

merged 1 commit into from
Jan 1, 2022

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 28, 2021

Updates libssh2-sys from 0.2.19 to 0.2.23. This brings in libssh2 1.10 (RELEASE-NOTES). One of the major changes is to add support for OpenSSH agent on Windows.

Closes rust-lang/cargo#10237

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jan 1, 2022

📌 Commit 000d336 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2022
@bors
Copy link
Contributor

bors commented Jan 1, 2022

⌛ Testing commit 000d336 with merge ad0d419...

@bors
Copy link
Contributor

bors commented Jan 1, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing ad0d419 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2022
@bors bors merged commit ad0d419 into rust-lang:master Jan 1, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 1, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ad0d419): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

bors added a commit to rust-lang/cargo that referenced this pull request Jan 2, 2022
Update docs for windows ssh-agent.

This updates the documentation for SSH authentication using Windows and ssh-agent.

Per #10237 and rust-lang/rust#92374, Cargo now supports ssh-agent on Windows.

I'm about 80% sure this information is correct based on my reading of the code and testing.  The ssh-agent that is part of mingw (or git-for-windows) uses emulated sockets, which are not compatible with traditional Windows-style named pipes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows OpenSSH ssh-agent not Supported by cargo from rustup
6 participants