Fix rustdoc::private_doc_tests lint for public re-exported items #92349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves changing the lint to check the access level is exported, rather than public. The exported access level accounts for public items and items accessible to other crates with the help of `pub use` re-exports. The pattern of re-exporting public items from a private module is usage seen in a number of popular crates.
rustbot
added
the
T-rustdoc
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
- Ensure standard public items are accepted - Ensure public items not re-exported from private modules are denied
avitex
force-pushed
the
fix-rustdoc-private-doc-tests
branch
from
9610afd to
992646b
Compare
|
Will this be able to make it to beta? I can rebase onto beta if needed |
GuillaumeGomez
approved these changes
Dec 28, 2021
|
I can nominate it to beta, but considering how old the issue is, I'm not sure it'll be accepted. In any case, I'll approve it once CI pass. |
|
If you can that would be great. It is low priority but cleans up an annoying little bug. If nomination requires any effort on my side like a rebase, happy to pick it up. |
|
Nothing on your side, it's done when the release is being done. They cherry-pick the commits from the nominated PRs and that's it. |
|
Awesome, thanks for letting me know |
GuillaumeGomez
added
the
beta-nominated
|
I added the tag to the PR and the compiler-team will discuss it at their next meeting once this PR is merged. |
rustbot
removed
the
beta-nominated
@GuillaumeGomez any updates? |
|
📌 Commit 992646b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#92058 (Make Run button visible on hover) - rust-lang#92288 (Fix a pair of mistyped test cases in `std::net::ip`) - rust-lang#92349 (Fix rustdoc::private_doc_tests lint for public re-exported items) - rust-lang#92360 (Some cleanups around check_argument_types) - rust-lang#92389 (Regression test for borrowck ICE rust-lang#92015) - rust-lang#92404 (Fix font size for [src] links in headers) - rust-lang#92443 (Rustdoc: resolve associated traits for non-generic primitive types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72081
This involves changing the lint to check the access level is exported, rather than public.
The exported access level accounts for public items and items accessible to other crates with the help of
pub usere-exports.The pattern of re-exporting public items from a private module is usage seen in a number of popular crates.