Visit expressions in-order when resolving pattern bindings #92237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
force-pushed
the
issue-92100
branch
from
3469479
to
99fa18c
Compare
compiler-errors
changed the title
cjgillot
reviewed
Dec 26, 2021
compiler/rustc_resolve/src/late.rs
Outdated
| @@ -1603,97 +1603,9 @@ impl<'a: 'ast, 'b, 'ast> LateResolutionVisitor<'a, 'b, 'ast> { | |||
| pat_src: PatternSource, | |||
| bindings: &mut SmallVec<[(PatBoundCtx, FxHashSet<Ident>); 1]>, | |||
| ) { | |||
| self.resolve_pattern_inner(pat, pat_src, bindings); | |||
| ResolvePatternWalker { late: self, pat_src, bindings }.visit_pat(pat); | |||
There was a problem hiding this comment.
Do we really need another visitor? We may risk forgetting part forwarding newly added methods between the two visitors.
Could the same results be achieved by calling walk_pat earlier?
Or could we have the ResolvePatternWalker restricted to patterns and not forwarding anything else?
There was a problem hiding this comment.
Actually that's a very good point. We can achieve the same behavior by calling walk_pat first, then declaring the bindings. Fixed up the PR to be much simpler.
compiler-errors
force-pushed
the
issue-92100
branch
from
99fa18c
to
b6756fd
Compare
|
r? @cjgillot |
cjgillot
added
S-waiting-on-author
compiler-errors
force-pushed
the
issue-92100
branch
from
b6756fd
to
b1529a6
Compare
|
@rustbot label -S-waiting-on-author +S-waiting-on-review |
rustbot
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit b1529a6 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#92075 (rustdoc: Only special case struct fields for intra-doc links, not enum variants) - rust-lang#92118 (Parse and suggest moving where clauses after equals for type aliases) - rust-lang#92237 (Visit expressions in-order when resolving pattern bindings) - rust-lang#92340 (rustdoc: Start cleaning up search index generation) - rust-lang#92351 (Add long error explanation for E0227) - rust-lang#92371 (Remove pretty printer space inside block with only outer attrs) - rust-lang#92372 (Print space after formal generic params in fn type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 7, 2022
…n-DPC Regression test for rust-lang#82866 Saw that this issue was open when i was cleaning my old branch for rust-lang#92237. I am also not opposed to not adding an extra test and just closing rust-lang#82866. Fixes rust-lang#82866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[edited:] Visit the pattern's sub-expressions before defining any bindings.
Otherwise, we might get into a case where a Lit/Range expression in a pattern has a qpath pointing to a Ident pattern that is defined after it, causing an ICE when lowering to HIR. I have a more detailed explanation in the issue linked.
Fixes #92100