Remove ArenaCacheSelector for visible_parent_map query

[In-line]

No description provided.

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[In-line]

Please, kindly schedule a perf run, in accordinness with #87349 (comment)

[Mark-Simulacrum]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit c44eee3 with merge 0c93ad62f49d9243ff8ffe7841f87266d31fd1ff...

[bors]

☀️ Try build successful - checks-actions
Build commit: 0c93ad62f49d9243ff8ffe7841f87266d31fd1ff (0c93ad62f49d9243ff8ffe7841f87266d31fd1ff)

[rust-timer]

Queued 0c93ad62f49d9243ff8ffe7841f87266d31fd1ff with parent 8ad3c1d, future comparison URL.

[rust-timer]

Finished benchmarking commit (0c93ad62f49d9243ff8ffe7841f87266d31fd1ff): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

• Moderate improvement in instruction counts (up to -2.6% on incr-patched: println builds of regression-31157)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[In-line]

Surprising results, that DefIdMap cloning has lower performance cost, than Lrc wrapper. What do you think @Mark-Simulacrum ?

[Mark-Simulacrum]

@bors try @rust-timer queue

I think this might've been some amount of noise when it was run, so let's re-check just in case.

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit c44eee3 with merge fa5f57f91c3963cd17ff478dd1f40cc7b2e14f98...

[bors]

☀️ Try build successful - checks-actions
Build commit: fa5f57f91c3963cd17ff478dd1f40cc7b2e14f98 (fa5f57f91c3963cd17ff478dd1f40cc7b2e14f98)

[rust-timer]

Queued fa5f57f91c3963cd17ff478dd1f40cc7b2e14f98 with parent 5883b87, future comparison URL.

[rust-timer]

Finished benchmarking commit (fa5f57f91c3963cd17ff478dd1f40cc7b2e14f98): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[Mark-Simulacrum]

Closing in favor of #92169.