-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for 1.58 #92055
Add release notes for 1.58 #92055
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
8c6bb58
to
e0a118c
Compare
e0a118c
to
ef91d2b
Compare
Co-authored-by: Hans Kratz <hans@appfour.com> Co-authored-by: Chris Denton <ChrisDenton@users.noreply.github.com> Co-authored-by: Joshua Nelson <github@jyn.dev>
ef91d2b
to
0928e52
Compare
All comments have been addressed (cc @rust-lang/release again). I'm officially on vacation starting tomorrow; I may check back here, but feel free to push to my branch / merge without me. |
Co-authored-by: Josh Triplett <josh@joshtriplett.org> Co-authored-by: Alexander Ronald Altman <alexanderaltman@me.com>
@bors r+ rollup |
📌 Commit 81963b1 has been approved by |
RELEASES.md
Outdated
- [`Duration::checked_mul`] | ||
- [`Duration::saturating_mul`] | ||
- [`Duration::checked_div`] | ||
- [`Duration::as_secs_f64`] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of the float methods are actually usable in const context: https://github.com/rust-lang/rust/blob/master/library/core/src/time.rs#L686
#89542 only stabilized:
impl Duration {
pub const fn new(secs: u64, nanos: u32) -> Duration;
pub const fn checked_add(self, rhs: Duration) -> Option<Duration>;
pub const fn saturating_add(self, rhs: Duration) -> Duration;
pub const fn checked_sub(self, rhs: Duration) -> Option<Duration>;
pub const fn saturating_sub(self, rhs: Duration) -> Duration;
pub const fn checked_mul(self, rhs: u32) -> Option<Duration>;
pub const fn saturating_mul(self, rhs: u32) -> Duration;
pub const fn checked_div(self, rhs: u32) -> Option<Duration>;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming this comment is correct.
Good catch @marmeladema, I'll fix it in a bit. @bors r- |
@bors r+ rollup |
📌 Commit 0e13d0c has been approved by |
[`Duration::checked_mul`]: https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.checked_mul | ||
[`Duration::saturating_mul`]: https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.saturating_mul | ||
[`Duration::checked_div`]: https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.checked_div | ||
[`Duration::as_secs_f64`]: https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.as_secs_f64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to remove those references?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shouldn't be publicly visible, someone can open a PR later removing that.
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92055 (Add release notes for 1.58) - rust-lang#92490 (Move crate drop-down to search results page) - rust-lang#92510 (Don't resolve blocks in foreign functions) - rust-lang#92573 (expand: Refactor InvocationCollector visitor for better code reuse) - rust-lang#92608 (rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes) - rust-lang#92657 (Implemented const casts of raw pointers) - rust-lang#92671 (Make `Atomic*::from_mut` return `&mut Atomic*`) - rust-lang#92673 (Remove useless collapse toggle on "all items" page) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
- [`Metadata::is_symlink`] | ||
- [`Path::is_symlink`] | ||
- [`{integer}::saturating_div`] | ||
- [`Option::unwrap_unchecked`] |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
r? @rust-lang/release