[experiment] perf-test smallvec optimizations #90673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 933ba6a236d051bbb3f002fae024f25c24391959 with merge 2652dd606cb092b25cbb78c7f1fce40f343c1ead... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
the
S-waiting-on-author
|
@bors retry |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
|
Looks like you added an old version of rust-analyzer to pr or something like that..? |
|
"old" being a few hours old here. I de-submoduled it because cargo couldn't vendor it with the custom overrides that I want to test and the overrides can't be applied to a submodule. But something went wrong somewhere. |
the8472
force-pushed
the
smallvec-experiment
branch
from
210fa25
to
45af45d
Compare
|
redid the commits, locally it cleanly merges into master now. @bors try |
bors
added
S-waiting-on-bors
|
@bors try |
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #90695) made this pull request unmergeable. Please resolve the merge conflicts. |
|
⌛ Trying commit 92def8dc40e70ed3c51d5e4d24e78e7197a887cd with merge 7dc2b6bb7610455b60e128dfdc8ccce52002f03f... |
|
☀️ Try build successful - checks-actions |
|
Queued 7dc2b6bb7610455b60e128dfdc8ccce52002f03f with parent d212d90, future comparison URL. |
|
Finished benchmarking commit (7dc2b6bb7610455b60e128dfdc8ccce52002f03f): comparison url. Summary: This change led to large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
rustbot
added
S-waiting-on-review
the8472
force-pushed
the
smallvec-experiment
branch
from
92def8d
to
179b167
Compare
|
Redoing the 2nd perf run now that #90996 has been merged. if that still skews more negative than the first one then my initial attempt will have been the best one and I'll propose that for inclusion in the small-vec crate. @bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
the8472
force-pushed
the
smallvec-experiment
branch
from
179b167
to
f91df9b
Compare
|
@bors try |
|
⌛ Trying commit f91df9b with merge e7d5196be5d77b51272c96329b5d976f449bcefc... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☔ The latest upstream changes (presumably #91604) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
removed
the
S-waiting-on-bors
|
Going to close this as a no-longer-relevant (I presume) perf experiment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost