Remove eval_always from upvars.

[cjgillot]

Split off #86056
r? @ghost

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 04f011f with merge 796a165526fe64e10911120021887580be2e8731...

[bors]

☀️ Try build successful - checks-actions
Build commit: 796a165526fe64e10911120021887580be2e8731 (796a165526fe64e10911120021887580be2e8731)

[rust-timer]

Queued 796a165526fe64e10911120021887580be2e8731 with parent 4961b10, future comparison URL.

[rust-timer]

Finished benchmarking commit (796a165526fe64e10911120021887580be2e8731): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

• Moderate improvement in instruction counts (up to -0.4% on incr-unchanged builds of many-assoc-items)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[Aaron1011]

LGTM. Let's do another perf run to make sure that nothing has changed since this was opened.

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 04f011f with merge d3ded1aef71b39954ec4b4fc7cfbfb2218d2bf82...

[bors]

☀️ Try build successful - checks-actions
Build commit: d3ded1aef71b39954ec4b4fc7cfbfb2218d2bf82 (d3ded1aef71b39954ec4b4fc7cfbfb2218d2bf82)

[rust-timer]

Queued d3ded1aef71b39954ec4b4fc7cfbfb2218d2bf82 with parent 883a241, future comparison URL.

[rust-timer]

Finished benchmarking commit (d3ded1aef71b39954ec4b4fc7cfbfb2218d2bf82): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

• Moderate improvement in instruction counts (up to -0.4% on incr-unchanged builds of many-assoc-items)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[Aaron1011]

@bors r+

[bors]

📌 Commit 04f011f has been approved by Aaron1011

[bors]

⌛ Testing commit 04f011f with merge b4b291a760dafc020b28e61ef835fe1d7ee5478f...

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

......... (50/53)
...        (53/53)


/checkout/src/test/rustdoc-gui/toggle-click-deadspace.goml toggle-click-deadspace... FAILED
[ERROR] (line 8) Error: Evaluation failed: assert didn't fail: for command `assert-attribute-false: (".impl-items .rustdoc-toggle", {"open": ""})`



command did not execute successfully: "/node-v14.4.0-linux-x64/bin/node" "/checkout/src/tools/rustdoc-gui/tester.js" "--jobs" "16" "--doc-folder" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc" "--tests-folder" "/checkout/src/test/rustdoc-gui"


Build completed unsuccessfully in 0:00:19

[bors]

💔 Test failed - checks-actions

[Aaron1011]

@bors retry

[bors]

⌛ Testing commit 04f011f with merge f5e758494b90eb33bff1759ddd9cc062d260348c...

[rust-log-analyzer]

The job x86_64-msvc-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    
    --- stdout
    
    running 6 tests
    test C:\Users\RUNNER~1\AppData\Local\Temp\mdbook-z0drDB\rust-2021/disjoint-capture-in-closures.md - Disjoint_capture_in_closures::Details (line 19) ... ignored
    test C:\Users\RUNNER~1\AppData\Local\Temp\mdbook-z0drDB\rust-2021/disjoint-capture-in-closures.md - Disjoint_capture_in_closures::Migration::Wild_Card_Patterns (line 68) ... ok
    test C:\Users\RUNNER~1\AppData\Local\Temp\mdbook-z0drDB\rust-2021/disjoint-capture-in-closures.md - Disjoint_capture_in_closures::Migration::Drop_Order (line 89) ... ok
    test C:\Users\RUNNER~1\AppData\Local\Temp\mdbook-z0drDB\rust-2021/disjoint-capture-in-closures.md - Disjoint_capture_in_closures::Migration::Drop_Order (line 102) ... ok
    test C:\Users\RUNNER~1\AppData\Local\Temp\mdbook-z0drDB\rust-2021/disjoint-capture-in-closures.md - Disjoint_capture_in_closures::Migration (line 51) ... ok
    test C:\Users\RUNNER~1\AppData\Local\Temp\mdbook-z0drDB\rust-2021/disjoint-capture-in-closures.md - Disjoint_capture_in_closures::Migration::Trait_implementations (line 150) ... FAILED
    failures:
    
    
    ---- C:\Users\RUNNER~1\AppData\Local\Temp\mdbook-z0drDB\rust-2021/disjoint-capture-in-closures.md - Disjoint_capture_in_closures::Migration::Trait_implementations (line 150) stdout ----
    Test executable failed (exit code -1073740791).
    
    failures:
    failures:
        C:\Users\RUNNER~1\AppData\Local\Temp\mdbook-z0drDB\rust-2021/disjoint-capture-in-closures.md - Disjoint_capture_in_closures::Migration::Trait_implementations (line 150)
    test result: FAILED. 4 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 2.19s
    
    
    --- stderr
---
Verifying status of rls...
Verifying status of miri...
Verifying status of embedded-book...
Cloning into 'rust-toolstate'...
error: Tool `edition-guide` has regressed from test-pass to test-fail during beta week.
{"rustbook":"test-fail","book":"test-pass","nomicon":"test-pass","rust-by-example":"test-pass","rls":"test-pass","edition-guide":"test-fail","reference":"test-pass","embedded-book":"test-pass","miri":"test-pass","cargo-miri":"test-fail"}Build completed unsuccessfully in 0:00:02

[bors]

💔 Test failed - checks-actions

[Aaron1011]

@bors retry

[bors]

⌛ Testing commit 04f011f with merge dd549dc...

[bors]

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing dd549dc to master...

[rust-timer]

Finished benchmarking commit (dd549dc): comparison url.

Summary: This change led to small relevant improvements 🎉 in compiler performance.

• Small improvement in instruction counts (up to -0.7% on incr-unchanged builds of style-servo)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression