Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Zassert-incr-state to assert state of incremental cache #90386

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Add -Zassert-incr-state to assert state of incremental cache #90386

merged 1 commit into from
Nov 18, 2021
+63 −4

Conversation

pierwill
Copy link
Member

@pierwill pierwill commented Oct 28, 2021 •
edited
Loading

Closes #85864.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2021
@pierwill pierwill marked this pull request as draft October 28, 2021 20:34
@pierwill
Copy link
Member Author

r? @Aaron1011

@rust-highfive rust-highfive assigned Aaron1011 and unassigned oli-obk Oct 28, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill pierwill force-pushed the assert-incr-state-85864 branch from 9fa372f to 0388331 Compare October 28, 2021 21:27
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jyn514
jyn514 reviewed Oct 29, 2021
View reviewed changes
compiler/rustc_incremental/src/persist/load.rs Outdated Show resolved Hide resolved
compiler/rustc_session/src/config.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill pierwill force-pushed the assert-incr-state-85864 branch from 7e6a02d to 4679489 Compare October 29, 2021 15:05
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill
Copy link
Member Author

Having trouble figuring out what's causing this panic. x check runs successfully.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill pierwill changed the title [WIP] Add -Zassert-incr-state to assert state of incremental cache [WIP] Add -Zassert-incr-state to assert state of incremental cache Oct 29, 2021
@pierwill pierwill changed the title [WIP] Add -Zassert-incr-state to assert state of incremental cache Add -Zassert-incr-state to assert state of incremental cache Oct 30, 2021
@pierwill pierwill marked this pull request as ready for review October 30, 2021 15:24
@pierwill pierwill force-pushed the assert-incr-state-85864 branch from 88cd57c to 1684347 Compare October 31, 2021 22:06
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Aaron1011 Aaron1011 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2021
@Aaron1011 Aaron1011 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 1, 2021
@pierwill pierwill force-pushed the assert-incr-state-85864 branch from 1684347 to b057f84 Compare November 3, 2021 17:23
@pierwill pierwill requested a review from Aaron1011 November 4, 2021 01:58
@pierwill pierwill force-pushed the assert-incr-state-85864 branch 3 times, most recently from 15eaf5f to 0c8da93 Compare November 8, 2021 19:47
@pierwill
Copy link
Member Author

pierwill commented Nov 9, 2021

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 11, 2021
@pierwill pierwill force-pushed the assert-incr-state-85864 branch from 0c8da93 to 1642fdf Compare November 12, 2021 19:41
@Aaron1011
Copy link
Member

Sorry for the delay in getting to this.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 17, 2021

📌 Commit 1642fdf has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…
a4739f2 
…=Aaron1011

Add `-Zassert-incr-state` to assert state of incremental cache

Closes rust-lang#85864.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 18, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
@JohnTitor
Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…
682a636 
…=Aaron1011

Add `-Zassert-incr-state` to assert state of incremental cache

Closes rust-lang#85864.
@JohnTitor JohnTitor mentioned this pull request Nov 18, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
@JohnTitor
Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…
b8a9cd4 
…=Aaron1011

Add `-Zassert-incr-state` to assert state of incremental cache

Closes rust-lang#85864.
@JohnTitor JohnTitor mentioned this pull request Nov 18, 2021
Closed
@JohnTitor JohnTitor mentioned this pull request Nov 18, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2021
@bors
Auto merge of rust-lang#91019 - JohnTitor:rollup-q95ra7r, r=JohnTitor
cc946fc 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#90386 (Add `-Zassert-incr-state` to assert state of incremental cache)
 - rust-lang#90438 (Clean up mess for --show-coverage documentation)
 - rust-lang#90480 (Mention `Vec::remove` in `Vec::swap_remove`'s docs)
 - rust-lang#90607 (Make slice->str conversion and related functions `const`)
 - rust-lang#90750 (rustdoc: Replace where-bounded Clean impl with simple function)
 - rust-lang#90895 (require full validity when determining the discriminant of a value)
 - rust-lang#90989 (Avoid suggesting literal formatting that turns into member access)
 - rust-lang#91002 (rustc: Remove `#[rustc_synthetic]`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 728b3f2 into rust-lang:master Nov 18, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@Aaron1011 Aaron1011 Awaiting requested review from Aaron1011

Assignees

@Aaron1011 Aaron1011

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

Add debugging flag to assert state of incremental cache
9 participants
@pierwill @rust-highfive @rust-log-analyzer @Aaron1011 @bors @jyn514 @oli-obk @apiraino @rustbot