Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable i8mm target feature on aarch64 and arm #90079

Merged
merged 2 commits into from
Oct 25, 2021
Merged

enable i8mm target feature on aarch64 and arm #90079

merged 2 commits into from
Oct 25, 2021

Conversation

SparrowLii
Copy link
Member

As in rust-lang/stdarch#1233, i8mm needs to be turned on to support the implementation of vmmla and vusmmlaneon instructions in stdarch.
r? @Amanieu

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@SparrowLii
Copy link
Member Author

SparrowLii commented Oct 20, 2021 •
edited
Loading

It seems that i8mm is still unavailable. In this case, we may not be able to support commands such as vmmla in stdarch for the time being.

@hkratz
Copy link
Contributor

hkratz commented Oct 20, 2021 •
edited
Loading

It seems that i8mm is still unavailable. In this case, we may not be able to support commands such as vmmla in stdarch for the time being.

It seems that LLVM 11 has support for i8mm, so once #90062 has landed this can go forward.

@Amanieu
Copy link
Member

Amanieu commented Oct 20, 2021

It's rather unfortunate that we don't have a proper way of extracting a list of supported features from LLVM. The current hack causes LLVM to print a message to stderr if a feature doesn't exist.

@Amanieu Amanieu mentioned this pull request Oct 21, 2021
Open
@hkratz
Copy link
Contributor

hkratz commented Oct 25, 2021

Minimum required LLVM version is now 12, so this can go in IMHO - #90175.

@SparrowLii SparrowLii changed the title enable i8mm target feature on aarch64 enable i8mm target feature on aarch64 and arm Oct 25, 2021
@SparrowLii
Copy link
Member Author

It seems that the i8mm feature can already be turned on on aarch64 and arm.
@Amanieu Can this PR be merged?

@Amanieu
Copy link
Member

Amanieu commented Oct 25, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 25, 2021

📌 Commit b88fcc1 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 25, 2021
@GuillaumeGomez
Rollup merge of rust-lang#90079 - SparrowLii:i8mm, r=Amanieu
fec654e 
enable `i8mm` target feature on aarch64 and arm

As in rust-lang/stdarch#1233, `i8mm` needs to be turned on to support the implementation of `vmmla` and `vusmmla`neon instructions in stdarch.
r? `@Amanieu`
This was referenced Oct 25, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2021
@bors
Auto merge of rust-lang#90265 - GuillaumeGomez:rollup-gx3ficp, r=Guil…
84c2a85 
…laumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#90017 (Add a couple tests for normalize under binder issues)
 - rust-lang#90079 (enable `i8mm` target feature on aarch64 and arm)
 - rust-lang#90233 (Tooltip overflow)
 - rust-lang#90257 (Changed slice.swap documentation for better readability)
 - rust-lang#90261 (Move back to linux builder on try builds)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bd48b99 into rust-lang:master Oct 25, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
7 participants
@SparrowLii @rust-log-analyzer @hkratz @Amanieu @bors @rust-highfive @rustbot