Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[must_use] to string/char transformation methods #89694

Merged
merged 2 commits into from
Oct 9, 2021
Merged

Add #[must_use] to string/char transformation methods #89694

merged 2 commits into from
Oct 9, 2021

Commits on Oct 9, 2021

  1. Add #[must_use] to string/char transformation methods 

    These methods could be misconstrued as modifying their arguments instead
of returning new values.

Where possible I made the note recommend a method that does mutate in
place.
    @jkugelman
    jkugelman committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    54d807c View commit details
    Browse the repository at this point in the history

  2. Update library/core/src/num/mod.rs 

    Co-authored-by: Josh Triplett <josh@joshtriplett.org>
    @jkugelman @joshtriplett
    jkugelman and joshtriplett committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    2ec7588 View commit details
    Browse the repository at this point in the history