Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test performance impact of removing untracked vtable cache from tcx #89602

Closed

Conversation

michaelwoerister
Copy link
Member

See #89598 for more information

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2021
@michaelwoerister
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 6, 2021
@bors
Copy link
Contributor

bors commented Oct 6, 2021

⌛ Trying commit 553a808 with merge 73d3bab7d9a52285b2738553971a9ab6f4a6cf11...

@bors
Copy link
Contributor

bors commented Oct 6, 2021

☀️ Try build successful - checks-actions
Build commit: 73d3bab7d9a52285b2738553971a9ab6f4a6cf11 (73d3bab7d9a52285b2738553971a9ab6f4a6cf11)

@rust-timer
Copy link
Collaborator

Queued 73d3bab7d9a52285b2738553971a9ab6f4a6cf11 with parent d7539a6, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (73d3bab7d9a52285b2738553971a9ab6f4a6cf11): comparison url.

Summary: This change led to moderate relevant regressions 😿 in compiler performance.

  • Moderate regression in instruction counts (up to 1.9% on full builds of ctfe-stress-4)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 6, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Oct 6, 2021

This is probably due to https://github.com/rust-lang/rustc-perf/blob/c7680837bb2b0a781ec2d7f1025b155ac64c0bc5/collector/benchmarks/ctfe-stress-4/src/lib.rs#L67 generating the same vtable a couple thousand times.

It's fine to regress this stress test in this way

@michaelwoerister
Copy link
Member Author

Alright, good to know we might have a simple fix if we can't do a proper one in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants