Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point at source of trait bound obligations in more places #89580

Merged
merged 11 commits into from
Nov 21, 2021
Merged

Point at source of trait bound obligations in more places #89580

merged 11 commits into from
Nov 21, 2021

Commits on Nov 20, 2021

  1. Point at source of trait bound obligations in more places 

    Be more thorough in using `ItemObligation` and `BindingObligation` when
evaluating obligations so that we can point at trait bounds that
introduced unfulfilled obligations. We no longer incorrectly point at
unrelated trait bounds (`substs-ppaux.verbose.stderr`).

In particular, we now point at trait bounds on method calls.

We no longer point at "obvious" obligation sources (we no longer have a
note pointing at `Trait` saying "required by a bound in `Trait`", like
in `associated-types-no-suitable-supertrait*`).

Address part of rust-lang#89418.
    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    6b9d910 View commit details
    Browse the repository at this point in the history

  2. Change trait_defs.rs incremental hash test 

    `predicates_of` no longer changes when changing a trait's front matter
because we no longer include the trait's span in the identity trait
obligation.
    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    d8a3d7d View commit details
    Browse the repository at this point in the history

  3. Point at bounds when comparing impl items to trait

    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    446b466 View commit details
    Browse the repository at this point in the history

  4. Do not mention associated items when they introduce an obligation

    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    563db42 View commit details
    Browse the repository at this point in the history

  5. Align multiline messages to their label (add left margin)

    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    8f433ad View commit details
    Browse the repository at this point in the history

  6. Point at impl blocks when they introduce unmet obligations 

    Group obligations by `impl` block that introduced them.
    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    9fa165d View commit details
    Browse the repository at this point in the history

  7. Suggest constraining fn type params when appropriate

    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    cecbd76 View commit details
    Browse the repository at this point in the history

  8. Move tests for missing trait bounds to their own directory

    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    55d50a9 View commit details
    Browse the repository at this point in the history

  9. review comments

    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    e30e47f View commit details
    Browse the repository at this point in the history

  10. Move tests from ui directory

    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    d5e982d View commit details
    Browse the repository at this point in the history

  11. bless NLL test

    @estebank
    estebank committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    2a2621d View commit details
    Browse the repository at this point in the history