-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the Lock into symbol::Interner #88978
Conversation
This makes it easier to make the symbol interner (near) lock free in case of concurrent accesses in the future.
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ccba8cb with merge 273547a8df9a9e7a9975c1623386ad1f5b39bcee... |
r=me presuming perf is OK. I'm not sure the 2nd and 3rd commits should be in this PR, but they seem okay anyway. |
☀️ Try build successful - checks-actions |
Queued 273547a8df9a9e7a9975c1623386ad1f5b39bcee with parent 2c7bc5e, future comparison URL. |
Finished benchmarking commit (273547a8df9a9e7a9975c1623386ad1f5b39bcee): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
A slight improvement for 2 benchmarks. No significant changes for the rest. @bors r=Mark-Simulacrum |
📌 Commit ccba8cb has been approved by |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6c33a0a): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This makes it easier to make the symbol interner (near) lock free in case of concurrent accesses in the future.
With #87867 landed this shouldn't affect performance anymore.