Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Lock into symbol::Interner #88978

Merged
merged 3 commits into from
Sep 18, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Sep 15, 2021

This makes it easier to make the symbol interner (near) lock free in case of concurrent accesses in the future.

With #87867 landed this shouldn't affect performance anymore.

This makes it easier to make the symbol interner (near) lock free in
case of concurrent accesses in the future.
@bjorn3 bjorn3 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 15, 2021
@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2021
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 15, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 15, 2021
@bors
Copy link
Contributor

bors commented Sep 15, 2021

⌛ Trying commit ccba8cb with merge 273547a8df9a9e7a9975c1623386ad1f5b39bcee...

@Mark-Simulacrum
Copy link
Member

r=me presuming perf is OK.

I'm not sure the 2nd and 3rd commits should be in this PR, but they seem okay anyway.

@bors
Copy link
Contributor

bors commented Sep 15, 2021

☀️ Try build successful - checks-actions
Build commit: 273547a8df9a9e7a9975c1623386ad1f5b39bcee (273547a8df9a9e7a9975c1623386ad1f5b39bcee)

@rust-timer
Copy link
Collaborator

Queued 273547a8df9a9e7a9975c1623386ad1f5b39bcee with parent 2c7bc5e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (273547a8df9a9e7a9975c1623386ad1f5b39bcee): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 15, 2021
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 15, 2021

A slight improvement for 2 benchmarks. No significant changes for the rest.

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Sep 15, 2021

📌 Commit ccba8cb has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Sep 15, 2021

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@bors
Copy link
Contributor

bors commented Sep 18, 2021

⌛ Testing commit ccba8cb with merge 6c33a0a...

@bors
Copy link
Contributor

bors commented Sep 18, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 6c33a0a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2021
@bors bors merged commit 6c33a0a into rust-lang:master Sep 18, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 18, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6c33a0a): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants