Add a better error message for #39364 #88612
Conversation
There is a known bug in the implementation of mpsc channels in rust. This adds a clearer error message when the bug occurs, so that developers don't lose too much time looking for the origin of the bug. See rust-lang#39364
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
joshtriplett
added
T-libs
|
Seems reasonable to me. Needs a rustfmt, but otherwise OK. I'm going to nominate this for a libs team meeting, so that we can discuss the broader issues around mpsc, and confirm that we want to make this change in the interim. |
|
I'm not sure I like the idea of refering to Rust and Rust issues from panic/error messages in the standard library. Messages from the compiler will be shown to the Rust developer, but messages like these will be shown to the user of the program, for who this might be quite meaningless or confusing. On the other hand, the alternative of just 'assertion failed' isn't much better of course. |
|
Discussed in the library meeting. Approving, since the new message is better than just the assert message with no context. @bors r+ rollup |
|
📌 Commit 598e5b2 has been approved by |
bors
added
S-waiting-on-bors
Add a better error message for rust-lang#39364 There is a known bug in the implementation of mpsc channels in rust. This adds a clearer error message when the bug occurs, so that developers don't lose too much time looking for the origin of the bug. See rust-lang#39364
…ingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#88612 (Add a better error message for rust-lang#39364) - rust-lang#89023 (Resolve issue : Somewhat confusing error with extended_key_value_attributes) - rust-lang#89148 (Suggest `_` in turbofish if param will be inferred from fn argument) - rust-lang#89171 (Run `no_core` rustdoc tests only on Linux) - rust-lang#89176 (Change singular to plural) - rust-lang#89184 (Temporarily rename int_roundings functions to avoid conflicts) - rust-lang#89200 (Fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
There is a known bug in the implementation of mpsc channels in rust.
This adds a clearer error message when the bug occurs, so that developers don't lose too much time looking for the origin of the bug.
See #39364