Rollup of 9 pull requests #88556
Merged
Rollup of 9 pull requests #88556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove extra commented code Deduplicate some diagnostics code add code symbols, machine applicable suggestion clarify error message
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
Associated types don't get bolded, so it looks off to have one kind bolded and one not.
POSIX says: > If successful, the readdir_r() function shall return zero; otherwise, > an error number shall be returned to indicate the error. But we were previously using errno instead of the return value. This led to issue rust-lang#86649.
…4, r=Mark-Simulacrum Emit specific warning to clarify that `#[no_mangle]` should not be applied on foreign statics or functions Foreign statics and foreign functions should not have `#[no_mangle]` applied, as it does nothing to the name and has some extra hidden behavior that is normally unwanted. There was an existing warning for this, but it says the attribute is only allowed on "statics or functions", which to the user can be confusing. This PR adds a specific version of the unused `#[no_mangle]` warning that explains that the target is a *foreign* static or function and that they do not need the attribute. Fixes rust-lang#78989
BTree: remove Ord bound from new
`K: Ord` bound is unnecessary on `BTree{Map,Set}::new` and their `Default` impl. No elements exist so there are nothing to compare anyway, so I don't think "future proof" would be a blocker here. This is analogous to `HashMap::new` not having a `K: Eq + Hash` bound.
rust-lang#79245 originally does this and for some reason drops the change to `new` and `Default`. I can see why changes to other methods like `entry` or `symmetric_difference` need to be careful but I couldn't find out any reason not to do it on `new`.
Removing the bound also makes the stabilisation of `const fn new` not depending on const trait bounds.
cc `@steffahn` who suggests me to make this PR.
r? `@dtolnay`
…jgillot Fix the flock fallback implementation
…ers, r=Amanieu add support for clobbering xer, cr, and cr[0-7] for asm! on OpenPower/PowerPC Fixes rust-lang#88315
…Gomez Remove bolding on associated constants Associated types don't get bolded, so it looks off to have one kind bolded and one not.
…uto-trait, r=petrochenkov fix(rustc_typeck): produce better errors for dyn auto trait Fixes rust-lang#85026
Use the return value of readdir_r() instead of errno POSIX says: > If successful, the readdir_r() function shall return zero; otherwise, > an error number shall be returned to indicate the error. But we were previously using errno instead of the return value. This led to issue rust-lang#86649.
…-ou-se Stabilize `Iterator::intersperse()` This PR stabilizes the methods `Iterator::intersperse()` and `Iterator::intersperse_with()`. The FCP has [already completed](rust-lang#79524 (comment)). Closes rust-lang#79524.
…get, r=m-ou-se Stabilize `UnsafeCell::raw_get()` This PR stabilizes the associated function `UnsafeCell::raw_get()`. The FCP has [already completed](rust-lang#66358 (comment)). While there was some discussion about the naming after the close of the FCP, it looks like people have agreed on this name. Still, it would probably be best if a `libs-api` member had a look at this and stated whether more discussion is needed. While I was at it, I added some tests for `UnsafeCell`, because there were barely any. Closes rust-lang#66358.
|
@bors r+ rollup=never p=5 |
|
📌 Commit d313529 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[no_mangle]should not be applied on foreign statics or functions #86376 (Emit specific warning to clarify that#[no_mangle]should not be applied on foreign statics or functions)Iterator::intersperse()#88548 (StabilizeIterator::intersperse())UnsafeCell::raw_get()#88551 (StabilizeUnsafeCell::raw_get())Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup