Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netbsd add backtrace lib since it is a system one. #88178

Closed
wants to merge 1 commit into from
Closed

netbsd add backtrace lib since it is a system one. #88178

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2021
@petrochenkov
Copy link
Contributor

Does libstd use functionality from this library? Probably not if it wasn't linked previously?
We usually only link libraries that are actually required and used by libstd, not just "system" libraries.

@devnexen
Copy link
Contributor Author

netbsd being a low tier platform, problems are not arise through CI, however it s needed, like FreeBSD, for backtrace purpose.

@bjorn3
Copy link
Member

bjorn3 commented Aug 21, 2021

Shouldn't this be added to the backtrace crate? https://github.com/rust-lang/backtrace-rs/

@inquisitivecrystal inquisitivecrystal added A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows O-netbsd Operating system: NetBSD T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows labels Aug 24, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2021
@joshtriplett
Copy link
Member

r? @yaahc

@rust-highfive rust-highfive assigned yaahc and unassigned joshtriplett Oct 4, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2022
@Dylan-DPC
Copy link
Member

@yaahc any updates on this?

@yaahc yaahc mentioned this pull request Feb 24, 2022
Open
4 tasks
@yaahc
Copy link
Member

yaahc commented Feb 24, 2022

@yaahc any updates on this?

Sorry about the delay on this one. On this specific issue I would like to reiterate the questions @petrochenkov and @bjorn3 asked. It's not clear to me what this PR accomplishes so I don't feel comfortable approving it without getting a better understanding.

In general though since this PR is touching our tier2/tier3 platforms, in accordance with the new target tier policy we'd like to identify designated maintainers for netbsd who can in the future handle reviews of this nature. I'm still figuring out what the process here should look like but I'm gonna start with searching through the history to see who has historically been involved in maintaining this target (these targets?) and open an issue / PR to invite and document them as the designated maintainers.

@yaahc yaahc mentioned this pull request Feb 24, 2022
Open
@yaahc
Copy link
Member

yaahc commented Mar 2, 2022

@rustbot label: -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2022
@devnexen
Copy link
Contributor Author

devnexen commented Mar 2, 2022

apologies for the late reply .. since this PR I have a dedicated netbsd hardware and sees this change is unneeded.

@devnexen devnexen closed this Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yaahc yaahc

Labels
O-netbsd Operating system: NetBSD S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@devnexen @rust-highfive @petrochenkov @bjorn3 @joshtriplett @Dylan-DPC @yaahc @JohnCSimon @inquisitivecrystal @rustbot