Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canonicalize consts before calling try_unify_abstract_consts query #88166

Merged
merged 3 commits into from
Aug 22, 2021
Merged

canonicalize consts before calling try_unify_abstract_consts query #88166

merged 3 commits into from
Aug 22, 2021

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Aug 19, 2021 •
edited
Loading

Fixes #88022
Fixes #86953
Fixes #77708
Fixes #82034
Fixes #85031

these ICEs were all caused by calling the try_unify_abstract_consts query with inference vars in substs

r? @lcnr

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2021
@BoxyUwU BoxyUwU force-pushed the const-equate-canon branch from fc4d559 to c2b61fb Compare August 19, 2021 20:04
@lcnr lcnr added F-generic_const_exprs `#![feature(generic_const_exprs)]` F-const_generics `#![feature(const_generics)]` labels Aug 19, 2021
@lcnr
Copy link
Contributor

lcnr commented Aug 19, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Aug 19, 2021

📌 Commit c2b61fb has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2021
@bors
Copy link
Contributor

bors commented Aug 22, 2021

⌛ Testing commit c2b61fb with merge 91f9806...

@bors
Copy link
Contributor

bors commented Aug 22, 2021

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 91f9806 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 22, 2021
@bors bors merged commit 91f9806 into rust-lang:master Aug 22, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 22, 2021
@lcnr lcnr added the A-const-generics Area: const generics (parameters and arguments) label Aug 26, 2021
@jethrogb jethrogb mentioned this pull request Oct 20, 2021
Merged
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
A-const-generics Area: const generics (parameters and arguments) F-const_generics `#![feature(const_generics)]` F-generic_const_exprs `#![feature(generic_const_exprs)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
5 participants
@BoxyUwU @lcnr @bors @rust-highfive @rustbot