Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of the expect attribute (RFC 2383) #87835

Merged
merged 13 commits into from
Mar 3, 2022
Merged

Implementation of the expect attribute (RFC 2383) #87835

merged 13 commits into from
Mar 3, 2022

Commits on Mar 2, 2022

  1. Added Expect lint level and attribute (RFC-2383) 

    * Also added the `LintExpectationId` which will be used in future commits
    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    9fef3d9 View commit details
    Browse the repository at this point in the history

  2. Added unfulfilled_lint_expectations lint for (RFC-2383)

    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    f467a58 View commit details
    Browse the repository at this point in the history

  3. Set LintExpectationId in level and collect fulfilled ones (RFC-2383) 

    * Collect lint expectations and set expectation ID in level (RFC-2383)
* Collect IDs of fulfilled lint expectations from diagnostics (RFC 2383)
    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    2ca9037 View commit details
    Browse the repository at this point in the history

  4. Check lint expectations and emit lint if unfulfilled (RFC-2383)

    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    44cb8fa View commit details
    Browse the repository at this point in the history

  5. Make LintExpectationId stable between compilation sessions (RFC-2383)

    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    33a5945 View commit details
    Browse the repository at this point in the history

  6. Add UI tests for the expect attribute (RFC-2383) 

    * Add UI tests with macros for the `expect` attribute (RFC-2383)
* Addressed review comments - mostly UI test updates (RFC-2383)
* Documented lint level attribute on macro not working bug (RFC-2383)
  See `rust#87391`
    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    a9bf9ea View commit details
    Browse the repository at this point in the history

  7. Expect each lint in attribute individually (RFC-2383)

    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    aa2a0a8 View commit details
    Browse the repository at this point in the history

  8. Test expect with forbid and fix doc errors (RFC-2383) 

    * Add test to expect and the forbid a lint (RFC 2383)
    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    43dc430 View commit details
    Browse the repository at this point in the history

  9. Reduced the size of LintExpectationId by 12 bytes (RFC-2383)

    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    a14456f View commit details
    Browse the repository at this point in the history

  10. Emit unfullfilled_lint_expectation using a HirId for performance … 

    …(RFC-2383)
    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    3414ad9 View commit details
    Browse the repository at this point in the history

  11. Added panics for unreachable states for expectations (RFC 2383)

    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    4887eb7 View commit details
    Browse the repository at this point in the history

  12. Address review comments

    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    defc056 View commit details
    Browse the repository at this point in the history

  13. Use Vec for expectations to have a constant order (RFC-2383)

    @xFrednet
    xFrednet committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    5275d02 View commit details
    Browse the repository at this point in the history