Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix anchors display in rustdoc #87818

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix anchors display in rustdoc #87818

merged 1 commit into from
Aug 19, 2021

Conversation

GuillaumeGomez
Copy link
Member

Fixes #87611 (it simplifies the positioning and fix the background).

Screenshot from 2021-08-06 16-47-03
Screenshot from 2021-08-06 16-47-10
Screenshot from 2021-08-06 16-47-14

r? @camelid

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Aug 6, 2021
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2021
@GuillaumeGomez
Copy link
Member Author

@camelid Is it good for you or is there something else to change?

@camelid
Copy link
Member

camelid commented Aug 16, 2021

I'll try to review this by Wednesday.

@jyn514
Copy link
Member

jyn514 commented Aug 16, 2021

@bors r=camelid - this seems fine and we can make improvements in follow-ups.

@bors
Copy link
Contributor

bors commented Aug 16, 2021

📌 Commit ea36352d6843b35f471afa29f0fab5524dcf93ea has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2021
@jyn514
Copy link
Member

jyn514 commented Aug 16, 2021

Oh sorry, github glitched and didn't show me your last comment.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2021
@jyn514 jyn514 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2021
camelid
camelid reviewed Aug 17, 2021
View reviewed changes
src/librustdoc/html/static/css/rustdoc.css
}
.anchor.field {
left: -5px;
}
.small-section-header > .anchor {
left: -28px;
padding-right: 10px; /* avoid gap that causes hover to disappear */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out this change locally, and it all looks good, except that the gap that causes the hover to disappear has cropped up in the new version. Is it possible to get rid of the gap?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gap only appears with headers like Implementations, not with enum variants.

@camelid
Copy link
Member

camelid commented Aug 17, 2021

r=me after something like #87818 (comment)

@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2021
@GuillaumeGomez GuillaumeGomez force-pushed the anchors-display-rustdoc branch from ea36352 to a927d56 Compare August 18, 2021 09:54
@GuillaumeGomez
Copy link
Member Author

Done! Interestingly enough, I couldn't reproduce the issue on firefox.

@GuillaumeGomez GuillaumeGomez force-pushed the anchors-display-rustdoc branch from a927d56 to dc24f02 Compare August 18, 2021 11:27
@GuillaumeGomez
Copy link
Member Author

@bors: r=camelid

@bors
Copy link
Contributor

bors commented Aug 18, 2021

📌 Commit dc24f02 has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 18, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87818 - GuillaumeGomez:anchors-display-rust…
e89c7d0 
…doc, r=camelid

Fix anchors display in rustdoc

Fixes rust-lang#87611 (it simplifies the positioning and fix the background).

![Screenshot from 2021-08-06 16-47-03](https://user-images.githubusercontent.com/3050060/128531105-61d1c21f-4a4d-4d68-aedf-9bfe0332f8ae.png)
![Screenshot from 2021-08-06 16-47-10](https://user-images.githubusercontent.com/3050060/128531109-b2ea8065-10b0-4400-9507-322122e42e78.png)
![Screenshot from 2021-08-06 16-47-14](https://user-images.githubusercontent.com/3050060/128531111-8a17cbdb-29e8-4baa-a0d6-81aa4f6ac6ed.png)

r? `@camelid`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 18, 2021
Merged
@camelid
Copy link
Member

camelid commented Aug 18, 2021

Done! Interestingly enough, I couldn't reproduce the issue on firefox.

Hmm, I found the issue using Firefox. I discovered it by moving my mouse somewhat slowly—it doesn't happen when my mouse is moved quickly—so maybe when you were trying to reproduce it you were moving your mouse too fast?

@GuillaumeGomez
Copy link
Member Author

So my superhuman speed was the issue! 🤣

@bors
Copy link
Contributor

bors commented Aug 19, 2021

⌛ Testing commit dc24f02 with merge 6d30039...

@bors
Copy link
Contributor

bors commented Aug 19, 2021

☀️ Test successful - checks-actions
Approved by: camelid
Pushing 6d30039 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 19, 2021
@bors bors merged commit 6d30039 into rust-lang:master Aug 19, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 19, 2021
@bors
Auto merge of rust-lang#88143 - GuillaumeGomez:rollup-sgh318f, r=Guil…
ad1eaff 
…laumeGomez

Rollup of 10 pull requests

Successful merges:

 - rust-lang#87818 (Fix anchors display in rustdoc)
 - rust-lang#87983 (Use more accurate spans when proposing adding lifetime to item)
 - rust-lang#88012 (Change WASI's `RawFd` from `u32` to `c_int` (`i32`).)
 - rust-lang#88031 (Make `BuildHasher` object safe)
 - rust-lang#88036 (Fix dead code warning when inline const is used in pattern)
 - rust-lang#88082 (Take into account jobs number for rustdoc GUI tests)
 - rust-lang#88109 (Fix environment variable getter docs)
 - rust-lang#88111 (Add background-color on clickable definitions in source code)
 - rust-lang#88129 (Fix dataflow graphviz bug, make dataflow graphviz modules public)
 - rust-lang#88136 (Move private_unused.rs test to impl-trait)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@rustbot rustbot added this to the 1.56.0 milestone Aug 19, 2021
@GuillaumeGomez GuillaumeGomez deleted the anchors-display-rustdoc branch August 19, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

Assignees

@camelid camelid

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

rustdoc: Section icon covers part of enum variant name when hovered
6 participants
@GuillaumeGomez @rust-highfive @camelid @jyn514 @bors @rustbot