Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf-check: Revert "Rollup merge of #87596" #87730

Closed
wants to merge 1 commit into from
Closed

perf-check: Revert "Rollup merge of #87596" #87730

wants to merge 1 commit into from

Conversation

JohnTitor
Copy link
Member

Checking the perf regression in #87640 (comment).
Only this PR touches rustc_ast in the rollup and it should affect the bootstrap time at least, let's see if this also causes the regression.
r? @ghost cc @Mark-Simulacrum

@JohnTitor
Revert "Rollup merge of rust-lang#87596 - jesyspa:issue-87318-hidden-…
3bb7c34 
…whitespace, r=estebank"

This reverts commit aa9e6aa, reversing
changes made to 5e2655d.
@JohnTitor
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 3, 2021
@bors
Copy link
Contributor

bors commented Aug 3, 2021

⌛ Trying commit 3bb7c34 with merge 2d70f86f6aa403c306f136178065b8ac93190aac...

@bors
Copy link
Contributor

bors commented Aug 3, 2021

☀️ Try build successful - checks-actions
Build commit: 2d70f86f6aa403c306f136178065b8ac93190aac (2d70f86f6aa403c306f136178065b8ac93190aac)

@rust-timer
Copy link
Collaborator

Queued 2d70f86f6aa403c306f136178065b8ac93190aac with parent 2939249, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (2d70f86f6aa403c306f136178065b8ac93190aac): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 3, 2021
@JohnTitor
Copy link
Member Author

Seems this one isn't, closing.

@JohnTitor JohnTitor closed this Aug 3, 2021
@JohnTitor JohnTitor deleted the revert-87596 branch August 3, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnTitor @rust-timer @bors @rustbot