Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min_type_alias_impl_trait in favor of type_alias_impl_trait #87501

Merged
merged 6 commits into from
Jul 28, 2021

Conversation

spastorino
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2021
@rust-log-analyzer

This comment has been minimized.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 27, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jul 27, 2021

📌 Commit 92ab09389af24a39c0a85c96cadf2001048ec6c6 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2021
@rust-log-analyzer

This comment has been minimized.

@spastorino
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jul 27, 2021

📌 Commit 9629d79 has been approved by oli-obk

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 27, 2021
Remove min_type_alias_impl_trait in favor of type_alias_impl_trait

r? `@oli-obk`
@spastorino
Copy link
Member Author

@bors r=oli-obk rollup=always

@bors
Copy link
Contributor

bors commented Jul 27, 2021

📌 Commit f16ae7e has been approved by oli-obk

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 28, 2021
Remove min_type_alias_impl_trait in favor of type_alias_impl_trait

r? `@oli-obk`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 28, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#87315 (Add docs for raw-dylib to unstable book)
 - rust-lang#87330 (Use hashbrown's `extend_reserve()` in `HashMap`)
 - rust-lang#87443 (Don't treat git repos as non-existent when `ignore_git` is set)
 - rust-lang#87453 (Suggest removing unnecessary &mut as help message)
 - rust-lang#87500 (Document math behind MIN/MAX consts on integers)
 - rust-lang#87501 (Remove min_type_alias_impl_trait in favor of type_alias_impl_trait)
 - rust-lang#87507 (SGX mutex is *not* moveable)
 - rust-lang#87513 (bootstrap.py: change `git log` option to indicate desired behavior)
 - rust-lang#87523 (Stop creating a reference then immediately dereferencing it.)
 - rust-lang#87524 (Fix ICE in `diagnostic_hir_wf_check`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 23479f7 into rust-lang:master Jul 28, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 28, 2021
@jhpratt
Copy link
Member

jhpratt commented Jul 29, 2021

I must've missed the conversation on this. Is this gate being removed because the soundness issues were resolved? If I'm remembering things correctly.

Alexendoo added a commit to Alexendoo/glacier that referenced this pull request Jul 29, 2021
It has been removed in favour of type_alias_impl_trait
rust-lang/rust#87501
@oli-obk
Copy link
Contributor

oli-obk commented Jul 29, 2021

I must've missed the conversation on this. Is this gate being removed because the soundness issues were resolved? If I'm remembering things correctly.

we're moving to a new system in which a min_tait system makes no sense anymore, as everything "just works" and is indeed sound

@jhpratt
Copy link
Member

jhpratt commented Jul 29, 2021

Awesome!

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 29, 2021
…version, r=jackh726

min_type_alias_impl_trait is going to be removed in 1.56

rust-lang#87501 removed `min_type_alias_impl_trait` but meanwhile that PR was approved in homu queue, a new beta was cut so we need to bump the version because it won't be removed in 1.55.

r? `@oli-obk`

`@bors` rollup=always
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jul 29, 2021
…version, r=jackh726

min_type_alias_impl_trait is going to be removed in 1.56

rust-lang#87501 removed `min_type_alias_impl_trait` but meanwhile that PR was approved in homu queue, a new beta was cut so we need to bump the version because it won't be removed in 1.55.

r? ``@oli-obk``

``@bors`` rollup=always
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 30, 2021
…version, r=jackh726

min_type_alias_impl_trait is going to be removed in 1.56

rust-lang#87501 removed `min_type_alias_impl_trait` but meanwhile that PR was approved in homu queue, a new beta was cut so we need to bump the version because it won't be removed in 1.55.

r? ```@oli-obk```

```@bors``` rollup=always
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants