Simplify typeck/primary_body_of, fix comment to match return signature #87465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
eddyb
approved these changes
Aug 8, 2021
Comment on lines
286
to
+288
| Node::ImplItem(item) => match item.kind { | ||
| hir::ImplItemKind::Const(ref ty, body) => Some((body, Some(ty), None, None)), | ||
| hir::ImplItemKind::Fn(ref sig, body) => { | ||
| Some((body, None, Some(&sig.header), Some(&sig.decl))) | ||
| } | ||
| hir::ImplItemKind::Const(ref ty, body) => Some((body, Some(ty), None)), | ||
| hir::ImplItemKind::Fn(ref sig, body) => Some((body, None, Some(&sig))), |
There was a problem hiding this comment.
|
📌 Commit 855fa13 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 855fa13 with merge 0aa151461201015b5ed488f43cfb4a96a6a46634... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry (looks spurious) |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, new contributor here! I'm carefully reading through the various modules just to learn. I noticed this function,
primary_body_of, which has gone through a couple of refactors over time, adding newOptions to its returned tuple. Observations:fn's documentation was not all up to date with the the current return signature.FnHeaderandFnDeclare always bothSomeorNone. So I figured it might just return a reference to the fullhir::FnSig, for simplicity and more precise typing. It's a pure refactor.I'm learning better by working with code than just reading it, so here goes! If you want to avoid pure refactor PRs that don't really fix anything, I can revert the code change to only update the comment instead.