Ignore comments in tidy-filelength

[ibraheemdev]

Ref #60302 (comment)

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[petrochenkov]

I disagree with this change, keeping comment lines short enough have the same value as keeping anything other text or code short.
We already have some logic in tidy applying exceptions to "special" comments like //~ ERROR text or comments containing URLs, which cannot be wrapped or shortened.

[ibraheemdev]

It's not just about being short, it's about readability. Comments don't add complexity to the file.

EDIT: I misinterpreted your comment as well 😄

[Mark-Simulacrum]

Hm, @petrochenkov - I don't think this PR changes behavior for line length checking. Line lengths are already ignored for most of the codebase: we avoid nagging people in files under rustfmt control. Whether that was the right call, I'm not sure, but this PR seems unrelated to that topic.

This PR seems to solely intend to avoid nagging on long files if the length is primarily due to comment lines. I think that's an interesting proposal, but as I personally don't really typically find file length an impediment or good proxy, I'm not sure I'm the right reviewer.

Regardless, for issues like this I think it's likely best to circulate them more widely; I would suggest a T-compiler MCP.

Cc @rust-lang/libs-contributors as well, since many of our longer files are such due to extensive documentation in std, core, etc.

[petrochenkov]

Ah, ok, sorry for misinterpreting the changes.
I'm ok with making files longer.

[Mark-Simulacrum]

Discussed during T-compiler meeting; no objections to just moving ahead were raised. Seems trivial to re-add if opposition is raised.

An additional point of discussion was the check might be dropped entirely, but that can also be proposed in the future with little trouble. It's possible being happier to ignore the lint is preferable, though, in cases where it is causing pain for no good reason.

@bors r+

[bors]

📌 Commit 3171bd5 has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 3171bd5 with merge 7129033...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7129033 to master...