Upgrade normalize.css to v8.0.1 #86725
Conversation
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
| } | ||
|
|
||
| /* end tweaks for normalize.css 8 */ | ||
|
|
||
| details:not(.rustdoc-toggle) summary { | ||
| margin-bottom: .6em; |
There was a problem hiding this comment.
NOTE: margin-bottom is still required.
|
Let's go with it and hope for the best I guess. Thanks! @bors: r+ |
|
📌 Commit 5101078 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
At a glance, I've noticed two changes: Beta
Nightly
The deprecation note width seems fine to me (actually, I messed up the screenshots on OP, sorry), but I'm happy to restore the original. The problem is the second, I think it's a regression and we should fix. But somehow I couldn't find it on testing. I generated the docs via @GuillaumeGomez I'd like to hear your thoughts. |
|
Please reset the deprecation notice. As for the position of the labels, it comes from this PR, so nothing to change on your side. @dns2utf8: Can we somehow fix the labels position while keeping them in the text by any chance?
Try emptying your cache? Otherwise the command line seems good to me. |
|
Alright, then I'll fix the first one later, thanks for checking! |
|
My changes were quite substantial and you must empty your css cache this time. They look like the ones currently on and they do not overlap with the current nightly. UpdateExcept for their position, which I changed because of mobile viewers. |
|
@dns2utf8 Yes, I was talking about the position. They are supposed to be positionned like the screenshot you provided. Do you think it's possible to keep them this way? If it requires too much changes, let's keep them as is. |
|
Moving the tags back to the right would be a big undertaking and to keep the benefits for mobile users and not reverting #86594 |
|
We could apply a "flex" style so that the left column first item (so before the "Experimental" and other labels) has the same width for all items when not on mobile? |
|
A flex layout in the left column could work, yes. Let us open an issue to focus there 👍 |
|
I let you do that then (odn't forget to ping me on it so I can add the tags). ;) |
|
After some investigating, turned out the first one also wasn't caused by this PR but #85970: https://github.com/rust-lang/rust/pull/85970/files#diff-7dc22a0530802d77c2f2ec9e834024a5657b6eab4055520fca46edc99a544413L855 |
|
I think the .stab problem has been solved already. However, I did not look into how exactly: |
|
I just checked on stable to ensure we were doing the right thing and apparently we're not:
However, I kinda like it as it is... |
|
@GuillaumeGomez So, let's say we do not restore (shrink) it for now? |
|
I'm good either way. |
|
Hmm alright, then I'll tweak it when someone issues it. |
This was added in 5101078, to fix the display of the module items and search results tables (see the discussion in rust-lang#86725). Those aren't tables any more. The only remaining table is in docblock, which has its own padding declarations.
This was added in 5101078, to fix the display of the module items and search results tables (see the discussion in rust-lang#86725). Those aren't tables any more. The only remaining table is in docblock, which needs this attribute to look right.
…aumeGomez rustdoc: merge CSS `table` rules into `.docblock` This was added in 5101078, to fix the display of the module items and search results tables (see the discussion in rust-lang#86725). Those aren't tables any more. The only remaining table is in docblock, which has its own padding declarations.
…aumeGomez rustdoc: merge CSS `table` rules into `.docblock` This was added in 5101078, to fix the display of the module items and search results tables (see the discussion in rust-lang#86725). Those aren't tables any more. The only remaining table is in docblock, which has its own padding declarations.
Fixes #86629, this addresses #82548 and #82542 with tweaks. I expect that this changes the style slightly but shouldn't have any major changes.
Here's some changes I observed, I'd say they all are an improvement.
Before
After
r? @jsha