Remove invalid suggestions for assoc consts on placeholder type error #86355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
JohnTitor
commented
Jun 16, 2021
Comment on lines
+1
to
+11
| error[E0121]: the type placeholder `_` is not allowed within types on item signatures | ||
| --> $DIR/type-placeholder-fn-in-const.rs:4:25 | ||
| | | ||
| LL | const TEST: fn() -> _; | ||
| | ^ not allowed in type signatures | ||
|
|
||
| error[E0121]: the type placeholder `_` is not allowed within types on item signatures | ||
| --> $DIR/type-placeholder-fn-in-const.rs:4:25 | ||
| | | ||
| LL | const TEST: fn() -> _; | ||
| | ^ not allowed in type signatures |
There was a problem hiding this comment.
This is unrelated to this PR but it seems we call placeholder_type_error twice for assoc consts of traits.
|
@bors r+ |
|
📌 Commit fb06d9e has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 16, 2021
Remove invalid suggestions for assoc consts on placeholder type error Fixes rust-lang#82158 This also moves some tests to typeck. r? `@estebank`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 17, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#85663 (Document Arc::from) - rust-lang#85802 (Rename IoSlice(Mut)::advance to advance_slice and add IoSlice(Mut)::advance) - rust-lang#85970 (Remove methods under Implementors on trait pages) - rust-lang#86340 (Use better error message for hard errors in CTFE) - rust-lang#86343 (Do not emit invalid suggestions on multiple mutable borrow errors) - rust-lang#86355 (Remove invalid suggestions for assoc consts on placeholder type error) - rust-lang#86389 (Make `sum()` and `product()` documentation hyperlinks refer to `Iterator` methods.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82158
This also moves some tests to typeck.
r? @estebank