Remove the install prefix from the rpath set when using -Crpath #86025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFG_PREFIX is incorrect for rustup installed rustc versions. It also causes unnecessary recompilation when changing the install prefix.
It was broken anyway for rustup installs and nobody seems to have noticed.
bjorn3
added
C-cleanup
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jackh726
approved these changes
Jun 6, 2021
|
@bors r+ |
|
📌 Commit 6b45d59 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 7, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#84262 (Fix ICE during type layout when there's a `[type error]`) - rust-lang#85973 (Replace a `match` with an `if let`) - rust-lang#85996 (rustbuild: take changes to the standard library into account for `download-rustc`) - rust-lang#86016 (Unify duplicate linker_and_flavor methods in rustc_codegen_{cranelift,ssa}.) - rust-lang#86025 (Remove the install prefix from the rpath set when using -Crpath) - rust-lang#86081 (Use `try_into` instead of asserting manually) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
81 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was broken anyway for rustup installs and nobody seems to have noticed.
Fixes #82392