Move LLVM submodule updates back to native.rs #86015
Conversation
This reverts commit ad30826.
jyn514
added
A-LLVM
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
It was a trivial function only used once.
|
Seems OK -- r=me, but I would prefer to land this when you have some cycles to either revert it or fix bugs that may pop up. Obviously, you know better than I when that is :) |
Mark-Simulacrum
added
S-waiting-on-author
|
Thanks :) I should have time this Friday afternoon |
|
@bors r=Mark-Simulacrum |
|
📌 Commit 73a40ac has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
FWIW, this appears to have the same behavior mentioned in #85647 that it unconditionally updates LLVM even if |
Yes, please do. Thanks! |
|
Filed #86954, thanks! |
…imulacrum Update all submodules that rustbuild doesn't depend on lazily This only updates the submodules the first time they're needed, instead of unconditionally the first time you run x.py. Ideally, this would move *all* submodules to rustbuild and not exclude some tools and backtrace. Unfortunately, cargo requires all `Cargo.toml` files in the whole workspace to be present to build any crate. On my machine, this takes the time for an initial submodule clone (for `x.py --help`) from 55.70 to 15.87 seconds. Helps with rust-lang#76653. Builds on rust-lang#86015 and should not be merged before (only the last commit is relevant).
Time to find more bugs!
The first commit is a straight revert of #85647, the second is a fix for https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/x.2Epy.20always.20updates.20LLVM.20submodule/near/240113320 and #82653 (comment). I haven't been able to replicate #82653 (comment).