Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop metadata_encoding_version. #85910

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Drop metadata_encoding_version. #85910

merged 2 commits into from
Jun 10, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jun 1, 2021

Part of #85153

r? @Aaron1011

@rust-highfive
Copy link
Collaborator

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2021
@Aaron1011
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2021
@bors
Copy link
Contributor

bors commented Jun 1, 2021

⌛ Trying commit 202d39a with merge 645e32b87f688454551ecbf295b7dd89710d5755...

@bors
Copy link
Contributor

bors commented Jun 1, 2021

☀️ Try build successful - checks-actions
Build commit: 645e32b87f688454551ecbf295b7dd89710d5755 (645e32b87f688454551ecbf295b7dd89710d5755)

@rust-timer
Copy link
Collaborator

Queued 645e32b87f688454551ecbf295b7dd89710d5755 with parent 7f9ab03, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (645e32b87f688454551ecbf295b7dd89710d5755): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 2, 2021
@cjgillot @bjorn3
Update compiler/rustc_metadata/src/rmeta/mod.rs
4e3b220 
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
@Aaron1011 Aaron1011 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2021
@Aaron1011
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 8, 2021
@bors
Copy link
Contributor

bors commented Jun 8, 2021

⌛ Trying commit 4e3b220 with merge 55280232445d2c365ae8c6f09dc7b0d5a48c7cad...

@bors
Copy link
Contributor

bors commented Jun 8, 2021

☀️ Try build successful - checks-actions
Build commit: 55280232445d2c365ae8c6f09dc7b0d5a48c7cad (55280232445d2c365ae8c6f09dc7b0d5a48c7cad)

@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 9, 2021

@rust-timer queue 55280232445d2c365ae8c6f09dc7b0d5a48c7cad

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 9, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Jun 9, 2021

⌛ Trying commit 4e3b220 with merge b755701d2aaf644d46f061499802503cf222214a...

@bors
Copy link
Contributor

bors commented Jun 9, 2021

☀️ Try build successful - checks-actions
Build commit: b755701d2aaf644d46f061499802503cf222214a (b755701d2aaf644d46f061499802503cf222214a)

@rust-timer
Copy link
Collaborator

Queued b755701d2aaf644d46f061499802503cf222214a with parent eab201d, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b755701d2aaf644d46f061499802503cf222214a): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 9, 2021
@Aaron1011
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 9, 2021

📌 Commit 4e3b220 has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2021
@bors
Copy link
Contributor

bors commented Jun 9, 2021

⌛ Testing commit 4e3b220 with merge b1a8af501c9bcc5ac1590fe8a5b66caebfc6213f...

@bors
Copy link
Contributor

bors commented Jun 10, 2021

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 10, 2021
@ehuss
Copy link
Contributor

ehuss commented Jun 10, 2021

@bors retry
aarch64-gnu self-hosted runner mysteriously died after 25 minutes, no logs available.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2021
@bors
Copy link
Contributor

bors commented Jun 10, 2021

⌛ Testing commit 4e3b220 with merge 1639a16...

@bors
Copy link
Contributor

bors commented Jun 10, 2021

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing 1639a16 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 10, 2021
@bors bors merged commit 1639a16 into rust-lang:master Jun 10, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 10, 2021
@cjgillot cjgillot deleted the no-meta-version branch June 10, 2021 06:49
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Jul 7, 2021
@bors
Auto merge of rust-lang#85910 - cjgillot:no-meta-version, r=Aaron1011
fa7545e 
Drop metadata_encoding_version.

Part of rust-lang#85153

r? `@Aaron1011`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@Aaron1011 Aaron1011

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
9 participants
@cjgillot @rust-highfive @Aaron1011 @rust-timer @bors @rust-log-analyzer @ehuss @bjorn3 @rustbot