Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsound TrustedRandomAccess implementations #85874

Merged
merged 8 commits into from
Jul 29, 2021
Merged

Remove unsound TrustedRandomAccess implementations #85874

merged 8 commits into from
Jul 29, 2021

Commits on Jul 28, 2021

  1. Remove unsound TrustedRandomAccess implementations 

    Removes the implementations that depend on the user-definable trait `Copy`.
    @steffahn
    steffahn committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    a0d8a32 View commit details
    Browse the repository at this point in the history

  2. Improve documentation of TrustedRandomAccess 

    Include new details regarding coercions to a subtype.
These conditions also explain why the previously removed implementations
for {array, vec, vec_deque}::IntoIter<T> were unsound, because they introduced
an extra `T: Clone` for the TrustedRandomAccess impl, even though their parameter T
is covariant.
    @steffahn
    steffahn committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    1c7f27f View commit details
    Browse the repository at this point in the history

  3. Add TrustedRandomAccessNoCoerce supertrait without requirements or gu… 

    …arantees about subtype coercions

Update all the TrustedRandomAccess impls to also implement the new supertrait
    @steffahn
    steffahn committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    69dd992 View commit details
    Browse the repository at this point in the history

  4. Change __iterator_get_unchecked to work with TrustedRandomAccessNoCoerce

    @steffahn
    steffahn committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    bbc6b26 View commit details
    Browse the repository at this point in the history

  5. Add back TrustedRandomAccess-specialization for Vec, but only without… 

    … coercions
    @steffahn
    steffahn committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    f9c982c View commit details
    Browse the repository at this point in the history

  6. Remove redundant bounds on get_unchecked for vec_deque iterators, and… 

    … run fmt
    @steffahn
    steffahn committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    9ff421d View commit details
    Browse the repository at this point in the history

  7. Make SpecInPlaceCollect use TrustedRandomAccessNoCoerce

    @steffahn
    steffahn committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    89583e9 View commit details
    Browse the repository at this point in the history

  8. Documentation improvements

    @steffahn
    steffahn committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6d9c0a1 View commit details
    Browse the repository at this point in the history