Replace parent substs of associated types with inference vars in borrow checker #85755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
spastorino
approved these changes
Jun 16, 2021
Normalization can pull in named regions from the parameter environment. We need to be prepared for that in the opaque types code.
nikomatsakis
force-pushed
the
unexpected_concrete_region
branch
from
fefc13c to
09eed28
Compare
|
@bors r+ |
|
📌 Commit 09eed28 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
oli-obk
added
beta-accepted
|
nominating and insta-accepting for beta backport since #83190 is still happening on beta |
|
This patch is already included in beta |
oli-obk
removed
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83190
Fixes #78450
When we normalize an associated type that refers to an opaque type, it can happen that the substs of the associated type do not occur in the projection (they are parent substs). We previously didn't replace those substs with inference vars, which left a concrete region after all regions should have already been replaced with inference vars and triggered a
delay_span_bug. After we normalize the opaque type, we now try to replace any remaining concrete regions with inference vars.