Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Auto merge of #83770 - the8472:tra-extend, r=Mark-Simulacrum" #85754

Merged
merged 1 commit into from
May 30, 2021
Merged

Revert "Auto merge of #83770 - the8472:tra-extend, r=Mark-Simulacrum" #85754

merged 1 commit into from
May 30, 2021

Conversation

the8472
Copy link
Member

@the8472 the8472 commented May 27, 2021 •
edited
Loading

Due to a performance regression that didn't show up in the original perf run
this reverts commit 9111b8a (#83770), reversing
changes made to 9a700d2.

Since since is expected to have the inverse impact it should probably be rollup=never.

r? @Mark-Simulacrum

@the8472
Revert "Auto merge of rust-lang#83770 - the8472:tra-extend, r=Mark-Si…
f72c60a 
…mulacrum"

Due to a performance regression that didn't show up in the original perf run
this reverts commit 9111b8a, reversing
changes made to 9a700d2.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented May 29, 2021

📌 Commit f72c60a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2021
@bors
Copy link
Contributor

bors commented May 30, 2021

⌛ Testing commit f72c60a with merge bff138d...

@bors
Copy link
Contributor

bors commented May 30, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing bff138d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 30, 2021
@bors bors merged commit bff138d into rust-lang:master May 30, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
5 participants
@the8472 @Mark-Simulacrum @bors @rust-highfive @rustbot