Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macros 2.0-ify rustc_arena #85690

Merged
merged 1 commit into from
Aug 28, 2021
Merged

Macros 2.0-ify rustc_arena #85690

merged 1 commit into from
Aug 28, 2021

Conversation

bstrie
Copy link
Contributor

@bstrie bstrie commented May 25, 2021 •
edited
Loading

For the purpose of battle-testing macros 2.0 I'm looking to dogfood it in rustc, one crate at a time.

(Note that there are only 12 changed lines if you ignore whitespace.)

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2021
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2021
@bstrie bstrie added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 14, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2021
@joelpalmer joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2021
@jackh726
Copy link
Member

This LGTM, but let's cc @rust-lang/compiler just to get a general sense of if this direction of "Macros 2.0-ifying" macros in rustc is direction we want to take.

Assuming compiler-team is on board, r=me

@nagisa
Copy link
Member

nagisa commented Aug 28, 2021

@bors r=jackh726,nagisa

@bors
Copy link
Contributor

bors commented Aug 28, 2021

📌 Commit 71db7cc has been approved by jackh726,nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2021
@bors
Copy link
Contributor

bors commented Aug 28, 2021

⌛ Testing commit 71db7cc with merge 5eacec9...

@bors
Copy link
Contributor

bors commented Aug 28, 2021

☀️ Test successful - checks-actions
Approved by: jackh726,nagisa
Pushing 5eacec9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2021
@bors bors merged commit 5eacec9 into rust-lang:master Aug 28, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
10 participants
@bstrie @rust-highfive @jackh726 @nagisa @bors @crlf0710 @estebank @JohnCSimon @joelpalmer @rustbot