Remove some last remants of {push,pop}_unsafe! #85421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #85273) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
|
📌 Commit 1ef61e84898f1bde0714153da07aa2702b56114d has been approved by |
bors
added
S-waiting-on-bors
|
@matthewjasper You approved before I resolved the merge conflicts -- I think you have to approve again? |
|
☔ The latest upstream changes (presumably #85954) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
These macros have already been removed, but there was still some code handling these macros. That code is now removed.
|
@bors r=matthewjasper |
|
📌 Commit 45c5554 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Jun 22, 2021
…eSeulArtichaut
Fix `unused_unsafe` around `await`
Enables `unused_unsafe` lint for `unsafe { future.await }`.
The existing test for this is `unsafe { println!() }`, so I assume that `println!` used to contain compiler-generated unsafe but this is no longer true, and so the existing test is broken. I replaced the test with `unsafe { ...await }`. I believe `await` is currently the only instance of compiler-generated unsafe.
Reverts some parts of rust-lang#85421, but the issue predates that PR.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 22, 2021
…eSeulArtichaut
Fix `unused_unsafe` around `await`
Enables `unused_unsafe` lint for `unsafe { future.await }`.
The existing test for this is `unsafe { println!() }`, so I assume that `println!` used to contain compiler-generated unsafe but this is no longer true, and so the existing test is broken. I replaced the test with `unsafe { ...await }`. I believe `await` is currently the only instance of compiler-generated unsafe.
Reverts some parts of rust-lang#85421, but the issue predates that PR.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 22, 2021
…eSeulArtichaut
Fix `unused_unsafe` around `await`
Enables `unused_unsafe` lint for `unsafe { future.await }`.
The existing test for this is `unsafe { println!() }`, so I assume that `println!` used to contain compiler-generated unsafe but this is no longer true, and so the existing test is broken. I replaced the test with `unsafe { ...await }`. I believe `await` is currently the only instance of compiler-generated unsafe.
Reverts some parts of rust-lang#85421, but the issue predates that PR.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 1, 2021
…jasper
Remove some last remants of {push,pop}_unsafe!
These macros have already been removed, but there was still some code handling these macros. That code is now removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These macros have already been removed, but there was still some code handling these macros. That code is now removed.