[stable] 1.52.1 release #85097
Merged
[stable] 1.52.1 release #85097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mark-Simulacrum: no appropriate reviewer found, use r? to override |
|
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
force-pushed
the
stable-next
branch
from
c84bb38 to
5e94af7
Compare
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
force-pushed
the
stable-next
branch
from
5e94af7 to
c6b04af
Compare
This comment has been minimized.
This comment has been minimized.
This disables incremental (i.e., -Cincremental) taking effect unless an environment variable, RUSTC_FORCE_INCREMENTAL, is set to 1 in the environment of the running rustc. Currently incremental causes errors for many users, and we do not have an expectation of being able to quickly fix these errors in a backportable way - so, for now, disable incremental entirely. The user can still opt-in, but this way the majority of users merely get slower builds, not broken builds.
This bumps the stable version number and adds corresponding release notes.
Mark-Simulacrum
force-pushed
the
stable-next
branch
from
c6b04af to
a0190b5
Compare
This was referenced May 9, 2021
|
@bors r+ rollup=never p=100 |
|
📌 Commit a0190b5 has been approved by |
bors
added
S-waiting-on-bors
wesleywiser
approved these changes
May 9, 2021
| Rust users **should** upgrade to 1.52.0 or 1.52.1: the bugs that are detected by | ||
| newly added incremental verification are still present in past stable versions, | ||
| and are not yet fixed on any channel. These bugs can lead to miscompilation of | ||
| Rust binaries. |
There was a problem hiding this comment.
Nit: I think it would be good to scope this sentence more tightly by moving the mention of incr comp from the next sentence up into this one. Ie: "Rust binaries when incremental compilation is enabled"
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this may not be the version we end up going with. However, in the interests of having the artifacts available should we choose to use them, this PR will prepare a set of artifacts which:
Note that the release notes mark Monday as the release date; I think it is likely that if we choose to go down this path we should indeed release on Monday, and potentially follow up in a week or two (e.g., May 20th) with a 1.52.2 if we have confidence in some collection of fixes. I think this will be unlikely, though.
Please also note that this PR breaks normal policy by landing commits/work only on the stable branch. It is my intent to follow up with PRs toward beta and master, as well, but in the interests of making sure we have artifacts as early as possible I am posting this first. It will also let us provide an ask for testing, via the dev-static bucket, sooner rather than later.