Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return EvaluatedToOk when type in outlives predicate is global #85090

Merged
merged 1 commit into from
Jul 4, 2021

Conversation

Aaron1011
Copy link
Member

A global type doesn't reference any local regions or types, so it's
guaranteed to outlive any region.

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 8, 2021
@bors
Copy link
Contributor

bors commented May 8, 2021

⌛ Trying commit 3341e59a51aae0f4e7563201909c9c40e741503b with merge 4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93...

@bors
Copy link
Contributor

bors commented May 8, 2021

☀️ Try build successful - checks-actions
Build commit: 4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93 (4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93)

@rust-timer
Copy link
Collaborator

Queued 4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93 with parent ff34b91, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 9, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 14, 2021
@bors
Copy link
Contributor

bors commented May 14, 2021

⌛ Trying commit 3341e59a51aae0f4e7563201909c9c40e741503b with merge 91eef17632935ce04682e8e7bdc0ce65a52370d9...

@bors
Copy link
Contributor

bors commented May 14, 2021

☀️ Try build successful - checks-actions
Build commit: 91eef17632935ce04682e8e7bdc0ce65a52370d9 (91eef17632935ce04682e8e7bdc0ce65a52370d9)

@rust-timer
Copy link
Collaborator

Queued 91eef17632935ce04682e8e7bdc0ce65a52370d9 with parent 17f30e5, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (91eef17632935ce04682e8e7bdc0ce65a52370d9): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 14, 2021
@bjorn3
Copy link
Member

bjorn3 commented May 14, 2021

Overall improvements up to 1.0% with 3 regressions of up to 0.5%.

@lcnr
Copy link
Contributor

lcnr commented May 24, 2021

I am not able to review any PRs in the near future.

r? @matthewjasper

@rust-highfive rust-highfive assigned matthewjasper and unassigned lcnr May 24, 2021
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 1, 2021

📌 Commit 3341e59a51aae0f4e7563201909c9c40e741503b has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2021
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2021
@crlf0710 crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 25, 2021
A global type doesn't reference any local regions or types, so it's
guaranteed to outlive any region.
@Aaron1011
Copy link
Member Author

@nikomatsakis: I added a region to Third, which preserves the existing EvaluatedToOk and EvaluatedToOkModuloRegions results.

@Aaron1011 Aaron1011 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2021
@jackh726
Copy link
Member

jackh726 commented Jul 3, 2021

@bors r=matthewjasper,jackh726

@bors
Copy link
Contributor

bors commented Jul 3, 2021

📌 Commit 1f7cb16 has been approved by matthewjasper,jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2021
@bors
Copy link
Contributor

bors commented Jul 3, 2021

⌛ Testing commit 1f7cb16 with merge cf65b707d871d443059f2b9881cfbd6cf31d850b...

@bors
Copy link
Contributor

bors commented Jul 3, 2021

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2021
@Aaron1011
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2021
@Aaron1011
Copy link
Member Author

This PR doesn't fix the root cause of the evaluate_obligation unstable fingerprint ICEs, but it should make them less common (since we'll never produce EvaluatedToOkModuloRegions in more cases).

@bors
Copy link
Contributor

bors commented Jul 3, 2021

⌛ Testing commit 1f7cb16 with merge d34a3a4...

@bors
Copy link
Contributor

bors commented Jul 4, 2021

☀️ Test successful - checks-actions
Approved by: matthewjasper,jackh726
Pushing d34a3a4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2021
@bors bors merged commit d34a3a4 into rust-lang:master Jul 4, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.