Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experiment] Eagerly expand cfg and cfg_attr in all attribute inputs #85073

Closed
wants to merge 3 commits into from

Conversation

petrochenkov
Copy link
Contributor

Based on #84995.
r? @Aaron1011

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2021
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 8, 2021
@bors
Copy link
Contributor

bors commented May 8, 2021

⌛ Trying commit a8c7b2a2d1480c233f0d66484d4a0ddc4354bde8 with merge b20a093d9fb1ffaa04ae9852cb034864a992bafd...

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2021
@bors
Copy link
Contributor

bors commented May 8, 2021

☀️ Try build successful - checks-actions
Build commit: b20a093d9fb1ffaa04ae9852cb034864a992bafd (b20a093d9fb1ffaa04ae9852cb034864a992bafd)

@rust-timer
Copy link
Collaborator

Queued b20a093d9fb1ffaa04ae9852cb034864a992bafd with parent 50e1dc1, future comparison URL.

@petrochenkov
Copy link
Contributor Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-85073 created and queued.
🤖 Automatically detected try build b20a093d9fb1ffaa04ae9852cb034864a992bafd
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 8, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b20a093d9fb1ffaa04ae9852cb034864a992bafd): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2021
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-85073 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-85073 is completed!
📊 14 regressed and 12 fixed (161086 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 29, 2021
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2021
@petrochenkov
Copy link
Contributor Author

Three root regressions:

  • inkwell - the #[llvm_versions] macro legitimately processes #[cfg]s is its input.
  • generic-tests - the #[generic_tests::define] macro legitimately processes #[cfg]s in its input.
  • twilight-gateway - behavior of the redundant_semicolons lint is changed somehow.

@petrochenkov
Copy link
Contributor Author

So, my conclusion is that it's a viable strategy, from both performance and compatibility point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants