Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM submodule #84681

Closed
wants to merge 1 commit into from
Closed

Update LLVM submodule #84681

wants to merge 1 commit into from

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Apr 29, 2021

Fixes #84025

@rust-highfive
Copy link
Collaborator

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2021
@alexcrichton alexcrichton mentioned this pull request Apr 30, 2021
Merged
@alexcrichton
Copy link
Member

This pulls in some wasm changes that failed to build clang at #84654 (comment). I think rust-lang/llvm-project#106 should fix the build failure, but in picking up that change in #84654 I've picked up this new commit to LLVM as well. I applied your test change in #84654 to include this there.

If that PR lands then this one I think can be closed (since it's included there)

@Amanieu
Copy link
Member Author

Amanieu commented Apr 30, 2021

This PR also fixes a test, I'll just wait for #84654 to be merged.

@bors
Copy link
Contributor

bors commented Apr 30, 2021

☔ The latest upstream changes (presumably #84654) made this pull request unmergeable. Please resolve the merge conflicts.

@Amanieu Amanieu closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI test asm/sym.rs fails with a linker error when executed with 1 CGU
5 participants
@Amanieu @rust-highfive @alexcrichton @bors @cuviper