Add documentation to help people find Ipv4Addr::UNSPECIFIED
#84257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @m-ou-se |
joshtriplett
changed the title
IpAddr::UNSPECIFIEDIpv4Addr::UNSPECIFIED
|
Looks like a good use case for |
joshtriplett
force-pushed
the
inaddr-any
branch
from
4d69bc2 to
5a6012a
Compare
|
@m-ou-se I'd be happy to add that as well, I just knew we were still discussing when that was appropriate to use. If you think it's fine in this case, I'll add it. |
People looking for `INADDR_ANY` don't always find `Ipv4Addr::UNSPECIFIED`; add some documentation and an alias to help.
joshtriplett
force-pushed
the
inaddr-any
branch
from
5a6012a to
9aa4d06
Compare
|
@bors r+ rollup |
|
📌 Commit 9aa4d06 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 17, 2021
Add documentation to help people find `Ipv4Addr::UNSPECIFIED` People looking for `INADDR_ANY` don't always find `Ipv4Addr::UNSPECIFIED`; add some documentation to help.
This was referenced Apr 17, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2021
Rollup of 4 pull requests Successful merges: - rust-lang#83237 (rustdoc: use more precise relative URLs) - rust-lang#84150 (rustdoc: move some search code into search.js) - rust-lang#84203 (rustdoc: Give a more accurate span for anchor failures) - rust-lang#84257 (Add documentation to help people find `Ipv4Addr::UNSPECIFIED`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People looking for
INADDR_ANYdon't always findIpv4Addr::UNSPECIFIED;add some documentation to help.