Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track -C link-dead-code during incremental compilation #84226

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Track -C link-dead-code during incremental compilation #84226

merged 1 commit into from
Apr 16, 2021

Conversation

Aaron1011
Copy link
Member

This option influences monomorphization, which participates in
incremental compilation.

@Aaron1011
Track -C link-dead-code during incremental compilation
1ce1cda 
This option influences monomorphization, which participates in
incremental compilation.
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2021
@Aaron1011 Aaron1011 mentioned this pull request Apr 15, 2021
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 15, 2021

📌 Commit 1ce1cda has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2021
@Mark-Simulacrum
Copy link
Member

I wonder if we should wrap the untracked values in some kind of Untracked<T>(T) newtype and force users to call read_untracked() or something like that. Maybe too noisy.

@bors
Copy link
Contributor

bors commented Apr 16, 2021

⌛ Testing commit 1ce1cda with merge e87c4dd...

@bors
Copy link
Contributor

bors commented Apr 16, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing e87c4dd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2021
@bors bors merged commit e87c4dd into rust-lang:master Apr 16, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 16, 2021
@xd009642 xd009642 mentioned this pull request Apr 16, 2021
Closed
@Aaron1011 Aaron1011 mentioned this pull request May 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Aaron1011 @rust-highfive @Mark-Simulacrum @bors @estebank @rustbot