-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categorize and explain target features support #84004
Categorize and explain target features support #84004
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
63f0546
to
5e7cb7a
Compare
This comment has been minimized.
This comment has been minimized.
It's quite possible that such "dichotomy" is an unintentional result of different features being implemented at different time by different people not having a vision of the larger picture, then it's not surprising that's not documented. |
5e7cb7a
to
f701247
Compare
The main thing here is to avoid documenting more guarantees than it was previously documented. |
ca5ac3f
to
e1a4e2b
Compare
This comment has been minimized.
This comment has been minimized.
e1a4e2b
to
e4c3cfe
Compare
r=me with commits squashed. |
e4c3cfe
to
e258a5b
Compare
@bors r+ |
📌 Commit e258a5b has been approved by |
☀️ Test successful - checks-actions |
There are 3 different uses of the
-C target-feature
args passed to rustc:cfg!(target_feature)
etc. These may have different names than in LLVM and are renamed before passing them to LLVM.#[target_feature]
.It can be confusing that
rustc --print target-features
just prints out the LLVM features without separating out the rustc features or even mentioning that the dichotomy exists.This improves the situation by separating out the rustc and LLVM target features and adding a brief explanation about the difference.
Abbreviated Example Output:
Motivated by #83975.
CC #49653