Implement a lint that highlights all moves larger than a configured limit #83519

oli-obk · 2021-03-26T16:32:38Z

Tracking issue: #83518
MCP 420 still ~~blazing~~ in progress

The main open issue I see with this minimal impl of the feature is that the lint is immediately "stable" (so it can be named on stable), even if it is never executed on stable. I don't think we have the concept of unstable lint names or hiding lint names without an active feature gate, so that would be a bigger change.

pnkfelix · 2021-04-01T20:01:32Z

src/test/ui/async-await/large_moves.rs

+// edition:2018
+
+fn main() {
+    let x = async { //~ ERROR large_assignments


I think this is a particularly interesting instance of the problem (and perhaps a huge motivation for this lint).

bors · 2021-04-02T18:03:34Z

☔ The latest upstream changes (presumably #83468) made this pull request unmergeable. Please resolve the merge conflicts.

JohnCSimon · 2021-04-18T23:44:51Z

@rustbot label: -S-waiting-on-review +S-waiting-on-author

pnkfelix · 2021-04-20T13:00:15Z

(i'll take over authorship here; oli already okayed me doing so.)

pnkfelix · 2021-04-20T18:26:35Z

(I rebased oli's work, but did not make any significant change to it so far. As long as I continue to not see any need for modifications, I think I can be trusted as a reviewer.)

pnkfelix · 2021-04-20T19:05:06Z

At some point, I think the people using this will want an easy to invoke it without having to modify their source code. Right now, you can do so on nightly by using these options:

rustc /tmp/large-stuff.rs '-Zcrate-attr=feature(large_assignments)' '-Zcrate-attr=move_size_limit="1000"'

(which is not perhaps ideal, but it is good enough for now for people to get their feet wet with this.)

pnkfelix · 2021-04-20T19:05:18Z

@bors r+ rollup

bors · 2021-04-20T19:05:20Z

📌 Commit 85b1c67 has been approved by pnkfelix

…ode, r=pnkfelix Implement a lint that highlights all moves larger than a configured limit Tracking issue: rust-lang#83518 [MCP 420](rust-lang/compiler-team#420) still ~blazing~ in progress r? `@pnkfelix` The main open issue I see with this minimal impl of the feature is that the lint is immediately "stable" (so it can be named on stable), even if it is never executed on stable. I don't think we have the concept of unstable lint names or hiding lint names without an active feature gate, so that would be a bigger change.

bors · 2021-04-21T08:02:16Z

⌛ Testing commit 85b1c67 with merge 1a254950b12c75287c4652d1dbfe2e08a3ab346f...

bors · 2021-04-21T08:09:47Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-04-21T08:36:00Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

JohnTitor · 2021-04-24T09:18:18Z

2021-04-21T08:02:23.5205676Z ##[section]Starting: Request a runner to run this job
2021-04-21T08:02:28.8016165Z Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest-xl'
2021-04-21T08:02:28.8467672Z Can't find any online and idle self-hosted runner in current repository's organization account that matches the required labels: 'ubuntu-latest-xl'
2021-04-21T08:02:28.9378485Z Found online and idle hosted runner in current repository's organization account that matches the required labels: 'ubuntu-latest-xl'
2021-04-21T08:02:29.0355646Z ##[section]Finishing: Request a runner to run this job

@bors retry

…ode, r=pnkfelix Implement a lint that highlights all moves larger than a configured limit Tracking issue: rust-lang#83518 [MCP 420](rust-lang/compiler-team#420) still ~blazing~ in progress r? `@pnkfelix` The main open issue I see with this minimal impl of the feature is that the lint is immediately "stable" (so it can be named on stable), even if it is never executed on stable. I don't think we have the concept of unstable lint names or hiding lint names without an active feature gate, so that would be a bigger change.

…ode, r=pnkfelix Implement a lint that highlights all moves larger than a configured limit Tracking issue: rust-lang#83518 [MCP 420](rust-lang/compiler-team#420) still ~blazing~ in progress r? ``@pnkfelix`` The main open issue I see with this minimal impl of the feature is that the lint is immediately "stable" (so it can be named on stable), even if it is never executed on stable. I don't think we have the concept of unstable lint names or hiding lint names without an active feature gate, so that would be a bigger change.

…ode, r=pnkfelix Implement a lint that highlights all moves larger than a configured limit Tracking issue: rust-lang#83518 [MCP 420](rust-lang/compiler-team#420) still ~blazing~ in progress r? ```@pnkfelix``` The main open issue I see with this minimal impl of the feature is that the lint is immediately "stable" (so it can be named on stable), even if it is never executed on stable. I don't think we have the concept of unstable lint names or hiding lint names without an active feature gate, so that would be a bigger change.

…ode, r=pnkfelix Implement a lint that highlights all moves larger than a configured limit Tracking issue: rust-lang#83518 [MCP 420](rust-lang/compiler-team#420) still ~blazing~ in progress r? ``@pnkfelix`` The main open issue I see with this minimal impl of the feature is that the lint is immediately "stable" (so it can be named on stable), even if it is never executed on stable. I don't think we have the concept of unstable lint names or hiding lint names without an active feature gate, so that would be a bigger change.

Rollup of 8 pull requests Successful merges: - rust-lang#83519 (Implement a lint that highlights all moves larger than a configured limit) - rust-lang#84105 (stabilize `core::array::{from_ref,from_mut}` in `1.53.0`) - rust-lang#84179 (Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`) - rust-lang#84427 (Update Clippy) - rust-lang#84459 (rustdoc: Turn `JsonRenderer::mod_item_in` into `unreachable!()`) - rust-lang#84460 (rustdoc: Remove unnecessary `is_crate` field from doctree::Module and clean::Module) - rust-lang#84464 (rustdoc: Get rid of `clean::TypeKind`) - rust-lang#84518 (Clean up DOM strings) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned pnkfelix Mar 26, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2021

This comment has been minimized.

Sign in to view

oli-obk force-pushed the assign_shrink_your_normal_code branch from 975b1c9 to d9b6528 Compare March 26, 2021 17:02

This comment has been minimized.

Sign in to view

oli-obk mentioned this pull request Mar 29, 2021

Tracking Issue for large_assignments lint #83518

Open

14 tasks

This comment has been minimized.

Sign in to view

oli-obk force-pushed the assign_shrink_your_normal_code branch from 205236b to 601f8af Compare March 29, 2021 15:58

pnkfelix reviewed Apr 1, 2021

View reviewed changes

bjorn3 mentioned this pull request Apr 15, 2021

Pass rustc the equivalent of -Wframe-larger-than=1000 Rust-for-Linux/linux#121

Open

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2021

oli-obk added 5 commits April 20, 2021 09:30

Implement a lint that highlights all moves larger than 1000 bytes

e9696c8

Add an attribute to be able to configure the limit

a2f2179

Tidy

a46bc56

Typo

6e988c0

Limit test to 64 bit systems to keep the sizes in the diagnostics stable

85b1c67

pnkfelix force-pushed the assign_shrink_your_normal_code branch from 601f8af to 85b1c67 Compare April 20, 2021 18:22

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 20, 2021

GuillaumeGomez mentioned this pull request Apr 20, 2021

Rollup of 8 pull requests #84375

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 21, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2021

Dylan-DPC-zz mentioned this pull request Apr 24, 2021

Rollup of 7 pull requests #84509

Closed

Dylan-DPC-zz mentioned this pull request Apr 24, 2021

Rollup of 7 pull requests #84512

Closed

JohnTitor mentioned this pull request Apr 24, 2021

Rollup of 6 pull requests #84517

Closed

This was referenced Apr 24, 2021

Rollup of 9 pull requests #84524

Closed

Rollup of 8 pull requests #84525

Merged

bors merged commit e109aa3 into rust-lang:master Apr 24, 2021

rustbot added this to the 1.53.0 milestone Apr 24, 2021

pnkfelix mentioned this pull request Oct 26, 2021

Lint for undesirable, implicit copies #45683

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement a lint that highlights all moves larger than a configured limit #83519

Implement a lint that highlights all moves larger than a configured limit #83519

oli-obk commented Mar 26, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pnkfelix Apr 1, 2021

bors commented Apr 2, 2021

JohnCSimon commented Apr 18, 2021

pnkfelix commented Apr 20, 2021

pnkfelix commented Apr 20, 2021

pnkfelix commented Apr 20, 2021

pnkfelix commented Apr 20, 2021

bors commented Apr 20, 2021

bors commented Apr 21, 2021

bors commented Apr 21, 2021

rust-log-analyzer commented Apr 21, 2021

JohnTitor commented Apr 24, 2021

Implement a lint that highlights all moves larger than a configured limit #83519

Implement a lint that highlights all moves larger than a configured limit #83519

Conversation

oli-obk commented Mar 26, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pnkfelix Apr 1, 2021

Choose a reason for hiding this comment

bors commented Apr 2, 2021

JohnCSimon commented Apr 18, 2021

pnkfelix commented Apr 20, 2021

pnkfelix commented Apr 20, 2021

pnkfelix commented Apr 20, 2021

pnkfelix commented Apr 20, 2021

bors commented Apr 20, 2021

bors commented Apr 21, 2021

bors commented Apr 21, 2021

rust-log-analyzer commented Apr 21, 2021

JohnTitor commented Apr 24, 2021