Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor WaitQueue out into a separate file #8327

Closed

Conversation

mstewartgallus
Copy link
Contributor

I'm a bit disappointed that I couldn't figure out how to factor out more of the code implementing extra::sync but I feel this is an okay start. Also I added some documentation explaining that WaitQueue isn't thread safe, and needs an exclusive lock.

@bblum

@bblum
Copy link
Contributor

bblum commented Aug 6, 2013

As I commented before, I don't see a reason the WaitQueue should be in its own file. There is nothing besides the rest of the stuff in sync that needs to use it.

Please poke me on IRC so we can discuss how to organize these modules. I think we have drastically different views of what the final version should end up looking like.

@mstewartgallus
Copy link
Contributor Author

So, me, and bblum had a long chat on IRC about this. We still have our disagreements about when modules should be split up into multiple files, and how encapsulated classes should be but I've compromised on a much less drastic change that would allow a possible split up if needed but does not split up sync.rs yet.

@bblum So I've changed the pull request.

bors added a commit that referenced this pull request Aug 10, 2013
I'm a bit disappointed that I couldn't figure out how to factor out more of the code implementing `extra::sync` but I feel this is an okay start. Also I added some documentation explaining that `WaitQueue` isn't thread safe, and needs an exclusive lock.
 
@bblum
@bors bors closed this Aug 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants