Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TryFrom, TryInto, FromIterator to the v1 prelude #82781

Closed
wants to merge 3 commits into from

Conversation

djc
Copy link
Contributor

@djc djc commented Mar 4, 2021

This is a test PR which I'd like to get a crater run for, as input to the 2021 prelude RFC. Please don't merge!

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2021
@djc
Copy link
Contributor Author

djc commented Mar 4, 2021

@bors try

@bors
Copy link
Contributor

bors commented Mar 4, 2021

@djc: 🔑 Insufficient privileges: not in try users

@rust-log-analyzer

This comment has been minimized.

@djc
Copy link
Contributor Author

djc commented Mar 4, 2021

PR for minifier here: GuillaumeGomez/minifier-rs#65.

@scottmcm scottmcm added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2021
@rust-log-analyzer

This comment has been minimized.

@djc djc force-pushed the test-2021-prelude branch from e5af1aa to 59d1e54 Compare March 5, 2021 19:06
@rust-log-analyzer

This comment has been minimized.

@djc djc force-pushed the test-2021-prelude branch from 59d1e54 to 1c33c00 Compare March 5, 2021 20:30
@rust-log-analyzer

This comment has been minimized.

@djc djc force-pushed the test-2021-prelude branch from 1c33c00 to 668ebf1 Compare March 5, 2021 21:42
@rust-log-analyzer

This comment has been minimized.

@m-ou-se
Copy link
Member

m-ou-se commented Mar 15, 2021

What's the status of this?

@djc
Copy link
Contributor Author

djc commented Mar 15, 2021

Status: this appears to be breaking some usage inside doctests, which appears to deny warnings by default (at least that is what is happening in the alloc crate). I've just pushed another change to fix that, so I'll see what else happens.

@djc
Copy link
Contributor Author

djc commented Mar 16, 2021

How can I get CI to run on this again?

@m-ou-se
Copy link
Member

m-ou-se commented Mar 16, 2021

@bors try

@bors
Copy link
Contributor

bors commented Mar 16, 2021

⌛ Trying commit a47eecd with merge b09a3e9a7a0ff7efb269ec0c13dcc0fd3cedcf6b...

@m-ou-se
Copy link
Member

m-ou-se commented Mar 16, 2021

Note that for a crater run we only need a try build, which doesn't run any tests. So even if the CI on the PR fails, we can still continue as long as rustc builds.

@bors
Copy link
Contributor

bors commented Mar 16, 2021

☀️ Try build successful - checks-actions
Build commit: b09a3e9a7a0ff7efb269ec0c13dcc0fd3cedcf6b (b09a3e9a7a0ff7efb269ec0c13dcc0fd3cedcf6b)

@djc
Copy link
Contributor Author

djc commented Mar 16, 2021

@m-ou-se can you request a crater experiment with this, or do I need to ask someone else?

@m-ou-se
Copy link
Member

m-ou-se commented Mar 16, 2021

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-82781 created and queued.
🤖 Automatically detected try build b09a3e9a7a0ff7efb269ec0c13dcc0fd3cedcf6b
⚠️ Try build based on commit 195ad48, but latest commit is a47eecd. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Mar 16, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-82781 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@m-ou-se
Copy link
Member

m-ou-se commented Mar 29, 2021

@rust-lang/infra Crater is stuck on generating the report. ^

@Mark-Simulacrum
Copy link
Member

@craterbot retry-report

@craterbot
Copy link
Collaborator

🛠️ Generation of the report for pr-82781 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-82781 is completed!
📊 5504 regressed and 17 fixed (151363 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 5, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Apr 9, 2021

Yay, we finally have a report.

As expected, lots of stuff breaks, which is why this needs to happen over an edition change.

Next step: Use this crater report to make a migration plan. We now have plenty of examples in which ways things break, and we can use this to come up with a migration lint that covers all/most of these cases. (This is a regular lint that can be run on Rust 2018 code and comes with a MachineApplicable suggestion to convert the code to something that compiles in both Rust 2018 and Rust 2021.) We don't need an implementation of this lint right now, but we do need a plan of what exactly this lint will detect and what it will suggest.

@JohnCSimon
Copy link
Member

this seems to still be in progress
@rustbot label: -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2021
@bstrie
Copy link
Contributor

bstrie commented May 12, 2021

I believe this PR can be closed, since it was just for crater and it has been decided that these changes require an edition.

@bstrie bstrie closed this May 12, 2021
@djc djc deleted the test-2021-prelude branch May 13, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.