-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TryFrom, TryInto, FromIterator to the v1 prelude #82781
Conversation
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try |
@djc: 🔑 Insufficient privileges: not in try users |
This comment has been minimized.
This comment has been minimized.
PR for minifier here: GuillaumeGomez/minifier-rs#65. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
What's the status of this? |
Status: this appears to be breaking some usage inside doctests, which appears to deny warnings by default (at least that is what is happening in the alloc crate). I've just pushed another change to fix that, so I'll see what else happens. |
How can I get CI to run on this again? |
@bors try |
⌛ Trying commit a47eecd with merge b09a3e9a7a0ff7efb269ec0c13dcc0fd3cedcf6b... |
Note that for a crater run we only need a |
☀️ Try build successful - checks-actions |
@m-ou-se can you request a crater experiment with this, or do I need to ask someone else? |
@craterbot check |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
@rust-lang/infra Crater is stuck on generating the report. ^ |
@craterbot retry-report |
🛠️ Generation of the report for ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
Yay, we finally have a report. As expected, lots of stuff breaks, which is why this needs to happen over an edition change. Next step: Use this crater report to make a migration plan. We now have plenty of examples in which ways things break, and we can use this to come up with a migration lint that covers all/most of these cases. (This is a regular lint that can be run on Rust 2018 code and comes with a |
this seems to still be in progress |
I believe this PR can be closed, since it was just for crater and it has been decided that these changes require an edition. |
This is a test PR which I'd like to get a crater run for, as input to the 2021 prelude RFC. Please don't merge!