Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand: Resolve and expand inner attributes on out-of-line modules #82399

Merged
merged 1 commit into from
Mar 14, 2021
Merged

expand: Resolve and expand inner attributes on out-of-line modules #82399

merged 1 commit into from
Mar 14, 2021

Conversation

petrochenkov
Copy link
Contributor

Fixes #81661
r? @Aaron1011

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2021
This was referenced Feb 22, 2021
Closed
Merged
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2021
@Aaron1011 Aaron1011 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2021
@Aaron1011
Copy link
Member

Could you add tests for #![cfg] and #[cfg_attr] in an outline module? r=me after that

@Aaron1011 Aaron1011 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
@petrochenkov
Copy link
Contributor Author

@bors r=Aaron1011

@bors
Copy link
Contributor

bors commented Feb 23, 2021

📌 Commit df78eea has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 24, 2021
@Dylan-DPC
Rollup merge of rust-lang#82399 - petrochenkov:modin2, r=Aaron1011
9e4cd83 
expand: Resolve and expand inner attributes on out-of-line modules

Fixes rust-lang#81661
r? `@Aaron1011`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 24, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 24, 2021
@Dylan-DPC
Rollup merge of rust-lang#82399 - petrochenkov:modin2, r=Aaron1011
cc0c8f1 
expand: Resolve and expand inner attributes on out-of-line modules

Fixes rust-lang#81661
r? ``@Aaron1011``
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 24, 2021
Closed
@Dylan-DPC-zz
Copy link

failed in rollup

@bors r-

@craterbot
Copy link
Collaborator

🎉 Experiment pr-82399 is completed!
📊 307 regressed and 14 fixed (147506 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 14, 2021
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2021
@petrochenkov
Copy link
Contributor Author

All the non-spurious regressions are #![rustfmt::skip].

@petrochenkov
Copy link
Contributor Author

Rebased and updated with a soft feature gate for #![rustfmt::skip] on out-of-line modules.

@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2021
@Aaron1011
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2021

📌 Commit a4cc3ca has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 14, 2021
@Dylan-DPC
Rollup merge of rust-lang#82399 - petrochenkov:modin2, r=Aaron1011
377542a 
expand: Resolve and expand inner attributes on out-of-line modules

Fixes rust-lang#81661
r? `@Aaron1011`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 14, 2021
Closed
@bors
Copy link
Contributor

bors commented Mar 14, 2021

⌛ Testing commit a4cc3ca with merge bb4cdf8...

@bors
Copy link
Contributor

bors commented Mar 14, 2021

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing bb4cdf8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2021
@bors bors merged commit bb4cdf8 into rust-lang:master Mar 14, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 14, 2021
@bors bors mentioned this pull request Mar 14, 2021
Merged
@nrc nrc mentioned this pull request Mar 16, 2021
Open
@petrochenkov petrochenkov mentioned this pull request Mar 17, 2021
Open
@luiswirth luiswirth mentioned this pull request Apr 18, 2021
Merged
@ehuss ehuss mentioned this pull request May 7, 2021
Closed
@Tim-Zhang Tim-Zhang mentioned this pull request May 21, 2021
Merged
Tim-Zhang added a commit to Tim-Zhang/ttrpc-rust that referenced this pull request May 21, 2021
@Tim-Zhang
Allow soft_unstable lint
c8b541a 
The #![rustfmt::skip] we used in ttrpc.rs has been
marked as soft_unstable in rust 1.52(rust-lang/rust#82399)

So we would got a build error like
`error: custom inner attributes are unstable`

This commit will fix this issue.

Signed-off-by: Tim Zhang <tim@hyper.sh>
@ehuss ehuss mentioned this pull request Jun 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaron1011 Aaron1011 Aaron1011 left review comments

Assignees

@Aaron1011 Aaron1011

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

Inner tool attributes emit spurious unused attribute warning
8 participants
@petrochenkov @Aaron1011 @bors @Dylan-DPC-zz @rust-log-analyzer @craterbot @rust-highfive @rustbot