Add trait name to conflicting implementation error message #8223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "conflicting implementations for a trait"); | ||
| session.span_err( | ||
| self.span_of_impl(implementation_b), | ||
| fmt!("conflicting implementations for trait %s", |
There was a problem hiding this comment.
nit: usually we use backticks around identifiers in error messages
|
@pcwalton Ok, I'll fix that when I get home tonight. |
|
@pcwalton backticks added. |
|
💃 |
bors
added a commit
that referenced
this pull request
Aug 3, 2013
Closes #7907 This is my first pull request so let me know if I've done anything wrong. I tried to pick off a nice easy one.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 13, 2022
Remove in_macro from clippy_utils changelog: none Previously done in rust-lang#7897 but reverted in rust-lang#8170. I'd like to keep `in_macro` out of utils because if a span is from expansion in any way (desugaring or macro), we should not proceed without understanding the nature of the expansion IMO. r? `@llogiq`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7907
This is my first pull request so let me know if I've done anything wrong. I tried to pick off a nice easy one.