-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no need to check assertion on fast path as will always hold. #82058
Conversation
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
r? @lcnr @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit b70428b with merge ebeae584970a367c0e843b436291ca9c78ad69cb... |
☀️ Try build successful - checks-actions |
Queued ebeae584970a367c0e843b436291ca9c78ad69cb with parent dd4851d, future comparison URL. |
Finished benchmarking try commit (ebeae584970a367c0e843b436291ca9c78ad69cb): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
mostly looks like noise @bors r+ |
📌 Commit b70428b has been approved by |
⌛ Testing commit b70428b with merge cd36bd46cc59a7dd156872eebf1ed652259b7c4c... |
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-actions |
V small change. Easy to review though!