Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no need to check assertion on fast path as will always hold. #82058

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

gilescope
Copy link
Contributor

V small change. Easy to review though!

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 13, 2021
@lcnr
Copy link
Contributor

lcnr commented Feb 13, 2021

r? @lcnr
after the perf run r=me

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-highfive rust-highfive assigned lcnr and unassigned dtolnay Feb 13, 2021
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 13, 2021
@bors
Copy link
Contributor

bors commented Feb 13, 2021

⌛ Trying commit b70428b with merge ebeae584970a367c0e843b436291ca9c78ad69cb...

@bors
Copy link
Contributor

bors commented Feb 13, 2021

☀️ Try build successful - checks-actions
Build commit: ebeae584970a367c0e843b436291ca9c78ad69cb (ebeae584970a367c0e843b436291ca9c78ad69cb)

@rust-timer
Copy link
Collaborator

Queued ebeae584970a367c0e843b436291ca9c78ad69cb with parent dd4851d, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (ebeae584970a367c0e843b436291ca9c78ad69cb): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 13, 2021
@lcnr
Copy link
Contributor

lcnr commented Feb 13, 2021

mostly looks like noise

@bors r+

@bors
Copy link
Contributor

bors commented Feb 13, 2021

📌 Commit b70428b has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2021
@bors
Copy link
Contributor

bors commented Feb 14, 2021

⌛ Testing commit b70428b with merge cd36bd46cc59a7dd156872eebf1ed652259b7c4c...

@bors
Copy link
Contributor

bors commented Feb 14, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 14, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@lcnr
Copy link
Contributor

lcnr commented Feb 14, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2021
@bors
Copy link
Contributor

bors commented Feb 16, 2021

⌛ Testing commit b70428b with merge f1c47c7...

@bors
Copy link
Contributor

bors commented Feb 16, 2021

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing f1c47c7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 16, 2021
@bors bors merged commit f1c47c7 into rust-lang:master Feb 16, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants