Allow overruling forbidden lints in derive macros #81087

bugadani · 2021-01-16T17:01:04Z

Fixes #71898 by allowing derive expansions to override forbidden lints that are set outside the expansion.

rust-highfive · 2021-01-16T17:01:08Z

(rust-highfive has picked a reviewer for you, use r? to override)

rust-log-analyzer · 2021-01-16T17:18:50Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

................i................................................................................... 6000/11260
............i........................................................i.............................. 6100/11260
............................................................................iiii.......i...i........ 6200/11260
.................................................................................................... 6300/11260
..................................i.........................i..................F.................... 6400/11260
.....FF..............................................................i..................FF.......... 6500/11260
...........................................ii..........................................i............ 6700/11260
.................................................................................................... 6800/11260
.................................................................................................... 6900/11260
..........................................i......................................................... 7000/11260
---
failures:

---- [ui] ui/error-codes/E0453.rs stdout ----

error: ui test compiled successfully!
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/error-codes/E0453.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0453" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0453/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------

------------------------------------------


---- [ui] ui/lint/issue-70819-dont-override-forbid-in-same-scope.rs stdout ----

error: ui test compiled successfully!
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/issue-70819-dont-override-forbid-in-same-scope.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/issue-70819-dont-override-forbid-in-same-scope" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "deduplicate-diagnostics=yes" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/issue-70819-dont-override-forbid-in-same-scope/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------

------------------------------------------


---- [ui] ui/lint/lint-forbid-cmdline.rs stdout ----

error: ui test compiled successfully!
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-forbid-cmdline.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-forbid-cmdline" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-F" "deprecated" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-forbid-cmdline/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------

------------------------------------------


---- [ui] ui/lint/lint-forbid-attr.rs stdout ----

error: ui test compiled successfully!
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-forbid-attr.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-forbid-attr" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-forbid-attr/auxiliary"
------------------------------------------

------------------------------------------
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
---


---- [ui] ui/lint/reasons-forbidden.rs stdout ----

error: ui test compiled successfully!
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/reasons-forbidden.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/reasons-forbidden" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "deduplicate-diagnostics=yes" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/reasons-forbidden/auxiliary"
------------------------------------------

------------------------------------------
stderr:
---

---- [ui] ui/lint/outer-forbid.rs stdout ----
diff of stderr:

- error[E0453]: allow(unused_variables) incompatible with previous forbid
-   --> $DIR/outer-forbid.rs:19:9
+ error: function is never used: `foo`
3    |
3    |
- LL | #![forbid(unused, non_snake_case)]
-    |           ------ `forbid` level set here
- LL | 
- LL | #[allow(unused_variables)]
-    |         ^^^^^^^^^^^^^^^^ overruled by previous forbid
- 
- error[E0453]: allow(unused) incompatible with previous forbid
-   --> $DIR/outer-forbid.rs:22:9
+ LL | fn foo() {}
12    |
12    |
- LL | #![forbid(unused, non_snake_case)]
-    |           ------ `forbid` level set here
- ...
- LL | #[allow(unused)]
-    |         ^^^^^^ overruled by previous forbid
- 
- error[E0453]: allow(nonstandard_style) incompatible with previous forbid
-   --> $DIR/outer-forbid.rs:25:9
+ note: the lint level is defined here
21    |
21    |
22 LL | #![forbid(unused, non_snake_case)]
-    |                   -------------- `forbid` level set here
- ...
- LL | #[allow(nonstandard_style)]
-    |         ^^^^^^^^^^^^^^^^^ overruled by previous forbid
+    |           ^^^^^^
+    = note: `#[forbid(dead_code)]` implied by `#[forbid(unused)]`
- error: aborting due to 3 previous errors
+ error: aborting due to previous error
29 
- For more information about this error, try `rustc --explain E0453`.
- For more information about this error, try `rustc --explain E0453`.
31 


The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/outer-forbid/outer-forbid.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args lint/outer-forbid.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/outer-forbid.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/outer-forbid" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "deduplicate-diagnostics=yes" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/outer-forbid/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error: function is never used: `foo`
   |
   |
LL | fn foo() {}
   |
note: the lint level is defined here
  --> /checkout/src/test/ui/lint/outer-forbid.rs:17:11
   |
   |
LL | #![forbid(unused, non_snake_case)]
   |           ^^^^^^
   = note: `#[forbid(dead_code)]` implied by `#[forbid(unused)]`
error: aborting due to previous error


------------------------------------------
---
test result: FAILED. 11168 passed; 6 failed; 86 ignored; 0 measured; 0 filtered out; finished in 136.31s



command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "ui" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python3" "--lldb-python" "/usr/bin/python3" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:14:50

rust-log-analyzer · 2021-01-16T17:45:02Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

...................................................i................................................ 11200/11260
............................................................
failures:

---- [ui] ui/lint/unused-qualification-in-derive.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/unused-qualification-in-derive.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused-qualification-in-derive" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused-qualification-in-derive/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error[E0453]: allow(unused_qualifications) incompatible with previous forbid
  --> /checkout/src/test/ui/lint/unused-qualification-in-derive.rs:4:10
   |
LL | #![forbid(unused_qualifications)]
   |           --------------------- `forbid` level set here
LL | 
LL | #[derive(Clone)]
   |          ^^^^^ overruled by previous forbid
   |
   = note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0453]: allow(unused_qualifications) incompatible with previous forbid
  --> /checkout/src/test/ui/lint/unused-qualification-in-derive.rs:4:10
   |
LL | #![forbid(unused_qualifications)]
   |           --------------------- `forbid` level set here
LL | 
LL | #[derive(Clone)]
   |          ^^^^^ overruled by previous forbid
   |
   = note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0453`.

---

Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "ui" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python3" "--lldb-python" "/usr/bin/python3" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:12:57

bugadani · 2021-01-16T17:48:52Z

Click to see the possible cause of the failure (guessed by this bot)

That's not the cause of the failure, that's the failure itself. I'm the cause of the failure 😅

oli-obk · 2021-01-16T19:22:33Z

This is a pretty big divergence from how we are handling forbid. Afaict this will make it possible to ignore forbids by wrapping an #![allow(something)] in a derive macro expansion. Of course it is limited to just derives, and the reasoning makes sense, but we should allow @rust-lang/wg-diagnostics and probably @rust-lang/lang to weigh in on this.

Mark-Simulacrum · 2021-01-16T19:54:24Z

I've nominated #80988 on a similar question and included this question there, as well, but we might discuss them separately in T-lang.

estebank · 2021-01-16T20:31:40Z

I agree that this is a t-lang level concern.

Aaron1011 · 2021-01-16T20:41:34Z

It feels somewhat arbitrary to only do this for derive macros, and to not provide a way of opting out of this. While derive macros do have meaningful differences (the inability to modify the original tokens, and receiving their input after cfg stripping), they are not the only kind of macro used to generate code. For example, the pin-project crate uses an attribute macro to generate an impl.

If we want to provide macros with the ability to override #[forbid], then I don't think it makes sense to limit this to derive macros. Conversely, I don't think that allowing this for derive macros without any kind of opt-in is a good idea. Many crates have helper proc-macro crates that are only used by the original crate - they would be combined into a single crate if we allowed that. In those cases, silently overriding a forbid is probably not what the crate author intended.

joshtriplett · 2021-01-17T23:35:38Z

Personally, I see this as part of the point of forbid: don't allow any code to do this, including things the crate might be unaware of or that may be added in the future. Applying that forbid to macros seems like a feature: it catches cases where you would otherwise be unaware of something being used.

If you want to disallow something, but allow overriding that from within a macro, use deny. If you want to disallow something, and not allow overriding that (from within a macro, or otherwise), use forbid. If we allow overriding forbid, it becomes redundant with deny.

So, either forbid(unused_qualifications) is incompatible with derive, or we should fix derive to avoid triggering that lint rather than allowing it.

joshtriplett · 2021-01-19T19:03:52Z

@scottmcm is posting some discussion of this to #80988 .

Based on discussion in a lang team meeting, we're not in favor of supporting allow-after-forbid, in macros or otherwise. The consensus was that if you use forbid, prohibiting allow is specifically the expected behavior, and people can switch to deny if they don't want that.

However, we're open to other solutions, such as:

Adding unused_qualifications to the existing list of lints we don't check in macro spans
Modifying derive to not trigger that lint, if that's possible

FCP-closing to confirm consensus.

@rfcbot close

rust-highfive assigned oli-obk Jan 16, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2021

bugadani force-pushed the derive-forbid branch from c6523b7 to 21fba5d Compare January 16, 2021 17:23

Allow overruling forbidden lints in derive macros

0981955

bugadani force-pushed the derive-forbid branch from 21fba5d to 0981955 Compare January 16, 2021 17:53

oli-obk added the I-needs-decision Issue: In need of a decision. label Jan 16, 2021

Mark-Simulacrum mentioned this pull request Jan 16, 2021

regression 1.50: deny after forbid breaks build #80988

Closed

bugadani closed this Jan 19, 2021

bugadani deleted the derive-forbid branch January 19, 2021 19:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow overruling forbidden lints in derive macros #81087

Allow overruling forbidden lints in derive macros #81087

bugadani commented Jan 16, 2021

rust-highfive commented Jan 16, 2021

rust-log-analyzer commented Jan 16, 2021

rust-log-analyzer commented Jan 16, 2021

bugadani commented Jan 16, 2021

oli-obk commented Jan 16, 2021

Mark-Simulacrum commented Jan 16, 2021

estebank commented Jan 16, 2021

Aaron1011 commented Jan 16, 2021

joshtriplett commented Jan 17, 2021

joshtriplett commented Jan 19, 2021

Allow overruling forbidden lints in derive macros #81087

Allow overruling forbidden lints in derive macros #81087

Conversation

bugadani commented Jan 16, 2021

rust-highfive commented Jan 16, 2021

rust-log-analyzer commented Jan 16, 2021

rust-log-analyzer commented Jan 16, 2021

bugadani commented Jan 16, 2021

oli-obk commented Jan 16, 2021

Mark-Simulacrum commented Jan 16, 2021

estebank commented Jan 16, 2021

Aaron1011 commented Jan 16, 2021

joshtriplett commented Jan 17, 2021

joshtriplett commented Jan 19, 2021